Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Rollback grpc from v1.33.2 to v1.27.1 #2724

Merged
merged 1 commit into from
Nov 10, 2020
Merged

deps: Rollback grpc from v1.33.2 to v1.27.1 #2724

merged 1 commit into from
Nov 10, 2020

Conversation

bobbypage
Copy link
Collaborator

@bobbypage bobbypage commented Nov 10, 2020 •
edited
Loading

Downgrade GRPC back to v1.27.1

grpc was previously upgraded in #2716 which resulted in issues vendoring latest release back into k/k due to grpc backwards incompatible change: kubernetes/kubernetes#93320

Ran below to downgrade grpc back to v1.27.1

go get -u google.golang.org/grpc@v1.27.1

@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@bobbypage
Copy link
Collaborator Author

/cc @dashpole @dims

@bobbypage bobbypage merged commit 805c665 into google:master Nov 10, 2020
@bobbypage bobbypage mentioned this pull request Nov 10, 2020
Merged
@dims dims mentioned this pull request Nov 12, 2020
Closed
@bobbypage bobbypage mentioned this pull request Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobbypage @dashpole