Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When no target set, flate2 fails to compile with latest HEAD #241

Closed
dae opened this issue Oct 8, 2020 · 1 comment
Closed

When no target set, flate2 fails to compile with latest HEAD #241

dae opened this issue Oct 8, 2020 · 1 comment

Comments

@dae
Copy link
Contributor

dae commented Oct 8, 2020 •
edited
Loading

Carrying on from #212 (comment)

To reproduce, checkout https://github.com/ankitects/cargo-raze-bug-examples and run repro.sh. Tested on a Mac.
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Nov 6, 2020
@GregBowyer
Rework planning to be based off the resolve tree and not directly pac…
18a6288 
…kages

There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunatly, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targetting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of sublte aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
@GregBowyer GregBowyer mentioned this issue Nov 6, 2020
Closed
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Nov 6, 2020
@GregBowyer
Rework planning to be based off the resolve tree and not directly pac…
4c6aa50 
…kages

There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunatly, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targetting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of sublte aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
@GregBowyer
Copy link
Contributor

I think I have solved this in #282

greg@gregslaptop /tmp $ git clone https://github.com/ankitects/cargo-raze-bug-examples.git
Cloning into 'cargo-raze-bug-examples'...
remote: Enumerating objects: 16, done.
remote: Counting objects: 100% (16/16), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 16 (delta 2), reused 16 (delta 2), pack-reused 0
Unpacking objects: 100% (16/16), 2.54 KiB | 520.00 KiB/s, done.
greg@gregslaptop /tmp $ cd cargo-raze-bug-examples/
greg@gregslaptop /tmp/cargo-raze-bug-examples $ cd cargo/
greg@gregslaptop .../cargo-raze-bug-examples/cargo $ cargo raze
Found unused raze crate settings for `log`
Found unused raze crate settings for `slog-stdlog`
Found unused raze crate settings for `h2`
Found unused raze crate settings for `unicase`
Found unused raze crate settings for `lexical-core`
Found unused raze crate settings for `mime_guess`
Found unused raze crate settings for `indexmap`
Found unused raze crate settings for `blake3`
Found unused raze crate settings for `typenum`
Found unused raze crate settings for `proc-macro-nested`
Found unused raze settings for version `>=1.12.0, <2.0.0` against crate `typenum`
Found unused raze settings for version `>=4.0.0, <5.0.0` against crate `slog-stdlog`
Found unused raze settings for version `>=1.6.0, <2.0.0` against crate `indexmap`
Found unused raze settings for version `>=2.0.3, <3.0.0` against crate `mime_guess`
Found unused raze settings for version `>=2.6.0, <3.0.0` against crate `unicase`
Found unused raze settings for version `>=0.7.4, <0.8.0` against crate `lexical-core`
Found unused raze settings for version `>=0.4.11, <0.5.0` against crate `log`
greg@gregslaptop .../cargo-raze-bug-examples/cargo $ ls
BUILD.bazel  Cargo.toml  crates.bzl  remote
greg@gregslaptop .../cargo-raze-bug-examples/cargo $ cd ..
greg@gregslaptop .../cargo-raze-bug-examples/repro $ bazel build //repro:*
INFO: SHA256 (https://crates.io/api/v1/crates/zip/0.5.8/download) = 543adf038106b64cfca4711c82c917d785e3540e04f7996554488f988ec43124
DEBUG: Rule 'raze__zip__0_5_8' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "543adf038106b64cfca4711c82c917d785e3540e04f7996554488f988ec43124"
DEBUG: Repository raze__zip__0_5_8 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:185:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/time/0.1.44/download) = 6db9e6914ab8b1ae1c260a4ae7a49b6c5611b40328a735b21862567685e73255
DEBUG: Rule 'raze__time__0_1_44' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "6db9e6914ab8b1ae1c260a4ae7a49b6c5611b40328a735b21862567685e73255"
DEBUG: Repository raze__time__0_1_44 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:131:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/crc32fast/1.2.1/download) = 81156fece84ab6a9f2afdb109ce3ae577e42b1228441eded99bd77f627953b1a
DEBUG: Rule 'raze__crc32fast__1_2_1' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "81156fece84ab6a9f2afdb109ce3ae577e42b1228441eded99bd77f627953b1a"
DEBUG: Repository raze__crc32fast__1_2_1 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:50:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/thiserror/1.0.22/download) = 0e9ae34b84616eedaaf1e9dd6026dbe00dcafa92aa0c8077cb69df1fcfe5e53e
DEBUG: Rule 'raze__thiserror__1_0_22' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "0e9ae34b84616eedaaf1e9dd6026dbe00dcafa92aa0c8077cb69df1fcfe5e53e"
DEBUG: Repository raze__thiserror__1_0_22 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:113:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/flate2/1.0.14/download) = 2cfff41391129e0a856d6d822600b8d71179d46879e310417eb9c762eb178b42
DEBUG: Rule 'raze__flate2__1_0_14' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "2cfff41391129e0a856d6d822600b8d71179d46879e310417eb9c762eb178b42"
DEBUG: Repository raze__flate2__1_0_14 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:59:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/byteorder/1.3.4/download) = 08c48aae112d48ed9f069b33538ea9e3e90aa263cfa3d1c24309612b1f7472de
DEBUG: Rule 'raze__byteorder__1_3_4' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "08c48aae112d48ed9f069b33538ea9e3e90aa263cfa3d1c24309612b1f7472de"
DEBUG: Repository raze__byteorder__1_3_4 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:23:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/cfg-if/1.0.0/download) = baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd
DEBUG: Rule 'raze__cfg_if__1_0_0' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd"
DEBUG: Repository raze__cfg_if__1_0_0 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:41:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/thiserror-impl/1.0.22/download) = 9ba20f23e85b10754cd195504aebf6a27e2e6cbe28c17778a0c930724628dd56
DEBUG: Rule 'raze__thiserror_impl__1_0_22' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "9ba20f23e85b10754cd195504aebf6a27e2e6cbe28c17778a0c930724628dd56"
DEBUG: Repository raze__thiserror_impl__1_0_22 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:122:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/miniz_oxide/0.3.7/download) = 791daaae1ed6889560f8c4359194f56648355540573244a5448a83ba1ecc7435
DEBUG: Rule 'raze__miniz_oxide__0_3_7' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "791daaae1ed6889560f8c4359194f56648355540573244a5448a83ba1ecc7435"
DEBUG: Repository raze__miniz_oxide__0_3_7 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:77:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/libc/0.2.80/download) = 4d58d1b70b004888f764dfbf6a26a3b0342a1632d33968e4a179d8011c760614
DEBUG: Rule 'raze__libc__0_2_80' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "4d58d1b70b004888f764dfbf6a26a3b0342a1632d33968e4a179d8011c760614"
DEBUG: Repository raze__libc__0_2_80 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:68:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/proc-macro2/1.0.24/download) = 1e0704ee1a7e00d7bb417d0770ea303c1bccbabf0ef1667dae92b5967f5f8a71
DEBUG: Rule 'raze__proc_macro2__1_0_24' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "1e0704ee1a7e00d7bb417d0770ea303c1bccbabf0ef1667dae92b5967f5f8a71"
DEBUG: Repository raze__proc_macro2__1_0_24 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:86:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/cfg-if/0.1.10/download) = 4785bdd1c96b2a846b2bd7cc02e86b6b3dbf14e7e53446c4f54c92a361040822
DEBUG: Rule 'raze__cfg_if__0_1_10' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "4785bdd1c96b2a846b2bd7cc02e86b6b3dbf14e7e53446c4f54c92a361040822"
DEBUG: Repository raze__cfg_if__0_1_10 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:32:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/syn/1.0.48/download) = cc371affeffc477f42a221a1e4297aedcea33d47d19b61455588bd9d8f6b19ac
DEBUG: Rule 'raze__syn__1_0_48' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "cc371affeffc477f42a221a1e4297aedcea33d47d19b61455588bd9d8f6b19ac"
DEBUG: Repository raze__syn__1_0_48 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:104:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/quote/1.0.7/download) = aa563d17ecb180e500da1cfd2b028310ac758de548efdd203e18f283af693f37
DEBUG: Rule 'raze__quote__1_0_7' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "aa563d17ecb180e500da1cfd2b028310ac758de548efdd203e18f283af693f37"
DEBUG: Repository raze__quote__1_0_7 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:95:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/adler32/1.2.0/download) = aae1277d39aeec15cb388266ecc24b11c80469deae6067e17a1a7aa9e5c1f234
DEBUG: Rule 'raze__adler32__1_2_0' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "aae1277d39aeec15cb388266ecc24b11c80469deae6067e17a1a7aa9e5c1f234"
DEBUG: Repository raze__adler32__1_2_0 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:14:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: SHA256 (https://crates.io/api/v1/crates/unicode-xid/0.2.1/download) = f7fe0bb3479651439c9112f72b6c505038574c9fbb575ed1bf3b797fa39dd564
DEBUG: Rule 'raze__unicode_xid__0_2_1' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "f7fe0bb3479651439c9112f72b6c505038574c9fbb575ed1bf3b797fa39dd564"
DEBUG: Repository raze__unicode_xid__0_2_1 instantiated at:
  /tmp/cargo-raze-bug-examples/WORKSPACE:45:25: in <toplevel>
  /tmp/cargo-raze-bug-examples/cargo/crates.bzl:140:10: in raze_fetch_remote_crates
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
Repository rule http_archive defined at:
  /home/greg/.cache/bazel/_bazel_greg/19065413c78595e4e0d63c939f529fee/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
INFO: Analyzed 3 targets (21 packages loaded, 585 targets configured).
INFO: Found 3 targets...
INFO: From Compiling Rust bin repro_bin (1 files):
warning: unused import: `zip`
 --> repro/repro.rs:1:5
  |
1 | use zip;
  |     ^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: 1 warning emitted

Target //repro:repro_bin up-to-date:
  bazel-bin/repro/repro_bin
INFO: Elapsed time: 19.211s, Critical Path: 17.46s
INFO: 8 processes: 1 internal, 7 linux-sandbox.
INFO: Build completed successfully, 8 total actions
greg@gregslaptop /tmp/cargo-raze-bug-examples $

GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Nov 6, 2020
@GregBowyer
Rework planning to be based off the resolve tree and not directly pac…
ab498e8 
…kages

There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunatly, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targetting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of sublte aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Nov 6, 2020
@GregBowyer
Rework planning to be based off the resolve tree and not directly pac…
eee6089 
…kages

There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunatly, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targetting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of sublte aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Nov 7, 2020
@GregBowyer
Rework planning to be based off the resolve tree and not directly pac…
4a89d7c 
…kages

There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunatly, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targetting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of sublte aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Nov 7, 2020
@GregBowyer
Rework planning to be based off the resolve tree and not directly pac…
74da68f 
…kages

There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunatly, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targetting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of sublte aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Nov 9, 2020
@GregBowyer
Rework planning to be based off the resolve tree and not directly pac…
1250290 
…kages

There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunatly, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targetting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of sublte aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Feb 4, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
22a9a2e 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Feb 4, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
d8cee86 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Feb 5, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
1c95d6e 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Apr 23, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
f73be78 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Apr 23, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
2da0f0e 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Apr 23, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
411fe34 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Apr 23, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
3018822 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Apr 23, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
8edc09d 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Apr 23, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
2063fd5 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
GregBowyer added a commit to GregBowyer/cargo-raze that referenced this issue Apr 24, 2021
@GregBowyer
Rework planning to use resolve tree and not packages
98a782b 
There are a range of subtle and irritating bugs that stem from
attempting to work with renames from the package set provided by cargo
metadata.

Fortunately, recent versions of cargo metadata provide a limited version
of the resolve nodes, both as the original node ids and as a newer set
providing both rename and targeting information.

As such we can (hopefully) simplify crate -> dep node resolution, remove
a bunch of subtle aliasing bugs.

Fixes google#241, fixes google#269, fixes google#270, resolves google#144, resolves google#187
@dfreese dfreese closed this as completed in 78617c1 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework planning to be based off the resolve tree and not directly pkgs GregBowyer/cargo-raze
2 participants
@GregBowyer @dae