Skip to content

Commit

Permalink
Add a workflow for checking unwanted @cel_spec dep in the runtime
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 705580925
  • Loading branch information
l46kok authored and copybara-github committed Dec 13, 2024
1 parent 692b009 commit c87f8d8
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
28 changes: 28 additions & 0 deletions .github/workflows/unwanted_deps.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#!/bin/bash
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# Script ran as part of Github CEL-Java CI to verify that the runtime jar does not contain generated cel protos from @cel_spec.

runtime_deps="$(bazel query 'deps(//publish:cel_runtime)' --nohost_deps --noimplicit_deps --output graph | grep '@cel_spec')"

if [[ ! -z $runtime_deps ]]; then
echo -e "Runtime contains unwanted @cel_spec dependency!\n"
echo "cel_spec dependency graph:"
echo -e "$runtime_deps"
exit 1
fi

exit 0

2 changes: 2 additions & 0 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,6 @@ jobs:
# Exclude codelab exercises as they are intentionally made to fail
# Exclude conformance tests for time being until TextFormat.Parser fix is in upstream
run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab,//conformance/src/test/java/dev/cel/conformance --test_output=errors
- name: Unwanted Dependencies
run: .github/workflows/unwanted_deps.sh
- run: echo "🍏 This job's status is ${{ job.status }}."

0 comments on commit c87f8d8

Please sign in to comment.