Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No unicode normalization: spec and tests. #125

Merged
merged 2 commits into from
Jun 21, 2020
Merged

No unicode normalization: spec and tests. #125

merged 2 commits into from
Jun 21, 2020

Conversation

JimLarson
Copy link
Contributor

Closes #124

TristonianJones
TristonianJones approved these changes Jun 19, 2020
View reviewed changes
Copy link
Collaborator

@TristonianJones TristonianJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM.

doc/langdef.md Outdated
outside of CEL, or done as a custom extension function.

Likewise, no advance collation is attempted on strings, as this depnds
on the normalization and can be local-dependent. Strings are simply treated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/local/locale

@JimLarson JimLarson merged commit fc9903f into google:master Jun 21, 2020
@JimLarson JimLarson deleted the unicode branch June 21, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristonianJones TristonianJones TristonianJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify lack of Unicode normalization
2 participants
@JimLarson @TristonianJones