Clarify homogeneous equality on lists and maps #128
Conversation
| For `double`, all not-a-number (`NaN`) values compare equal. This is different | ||
| than the usual semantics of floating-point numbers, but it is more consistent | ||
| with the usual expectations of reflexivity, and is more compatible with the | ||
| usual notions of equality on protocol buffers. |
There was a problem hiding this comment.
FYI, The default for protobuf differencer is to consider NaN == Nan -> False. You have to explicitly specify if you want a different behavior: https://github.com/protocolbuffers/protobuf/blob/582558a58923b51c7226bb176faaf220bc6840ab/src/google/protobuf/util/field_comparator.h#L130
https://github.com/protocolbuffers/protobuf/blob/582558a58923b51c7226bb176faaf220bc6840ab/src/google/protobuf/util/field_comparator.cc#L53
Also, what about -0 vs 0?
There was a problem hiding this comment.
Also, why not do the 'right' thing and represent 'not a number' by the existing 'not a value'/falsum/bottom concept in CEL, i.e. an error. I believe this is how CEL fixes integer overflows. You could even just make it so this only pops up when performing operations with NaN, so NaN itself is still observable from within the expression.
There was a problem hiding this comment.
Also, what is:
- NaN < 0.0
- NaN <= NaN
- 0 > -0
Updates spec and adds conformance tests.
Closes #127