Document overflow behavior, add tests. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #131 |
| @@ -827,6 +827,12 @@ values. The ordering operators obey the usual algebraic properties, i.e. `e1 <= | |||
| e2` gives the same result as `!(e1 > e2)` as well as `(e1 < e2) || (e1 == e2)` | |||
| when the expressions involved do not have side effects. | |||
|
|
|||
| ### Overflow | |||
There was a problem hiding this comment.
Could we add a test to ensure negating the minimum int value will overflow?
There was a problem hiding this comment.
Done. Thanks, good catch. In cel-go it wraps back to itself, but for consistency we should expect an error.
|
PTAL |
| } | ||
| test { | ||
| name: "int64_min_negate" | ||
| description: "Negated LLONG_MIN is not representable." |
There was a problem hiding this comment.
nit: extra L in LONG?
There was a problem hiding this comment.
I think Gabriel was using standard C constants, where "long" might only be 32-bits, so it's for "long long min", guaranteeing at least 64 bits. Long long could be bigger than that, but C's flexibility for integer sizes is mostly theoretical these days - at least outside the embedded market.
TristonianJones
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.