-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golang module for canonical protos. Move existing go module under tests #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
approved these changes
Mar 20, 2024
sergiitk
reviewed
Mar 20, 2024
sergiitk
reviewed
Mar 20, 2024
sergiitk
reviewed
Mar 20, 2024
sergiitk
reviewed
Mar 20, 2024
l46kok
force-pushed
the
move-test-protos-to-submodule
branch
from
March 21, 2024 19:14
e6233d1
to
9413025
Compare
TristonianJones
previously approved these changes
Mar 22, 2024
@l46kok you might want to setup .gitattributes to mark pb.go files binary. |
See https://github.com/cncf/xds/blob/6b7cb9e61ad79c99765a1dea2bede517d1b7db3e/.gitattributes#L1-L2
|
l46kok
force-pushed
the
move-test-protos-to-submodule
branch
2 times, most recently
from
March 22, 2024 20:20
fc225e8
to
2f78ea9
Compare
l46kok
force-pushed
the
move-test-protos-to-submodule
branch
from
March 22, 2024 20:21
2f78ea9
to
d8bbb06
Compare
PTAL |
TristonianJones
approved these changes
Mar 26, 2024
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to allow serving canonical protos
cel.dev/expr
for golang viago get cel.dev/expr
.