Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance tests for 'null' assignment to a field #367

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conformance tests for 'null' assignment to a field #367

merged 1 commit into from
Jul 31, 2024

Conversation

TristonianJones
Copy link
Collaborator

@TristonianJones TristonianJones commented Jul 23, 2024 •
edited
Loading

Conformance tests for 'null' assignment to a field

Generally, setting a proto field to null within a CreateStruct block
should result in the field being unset; however, there are some exceptions:

  • Repeated and map fields cannot be unset via null
  • The google.protobuf.Any and google.protobuf.Value types
    treat null as a concrete JSON null

@TristonianJones TristonianJones force-pushed the null-conformance-tests branch 6 times, most recently from 6a757e2 to 581df89 Compare July 26, 2024 16:43
@TristonianJones TristonianJones changed the title Test assigning a wrapper type null Conformance tests for 'null' assignment to a field Jul 26, 2024
@TristonianJones TristonianJones marked this pull request as ready for review July 26, 2024 18:47
@TristonianJones TristonianJones merged commit 5e68cde into google:master Jul 31, 2024
2 checks passed
@TristonianJones TristonianJones deleted the null-conformance-tests branch July 31, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcking jcking jcking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TristonianJones @jcking