Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the standard function docs #386

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

TristonianJones
Copy link
Collaborator

Provide more useful documentation for the CEL types, functions, and macros

@TristonianJones TristonianJones removed the request for review from jnthntatum August 28, 2024 18:05
doc/langdef.md Show resolved Hide resolved
doc/langdef.md Show resolved Hide resolved
doc/langdef.md Outdated Show resolved Hide resolved
doc/langdef.md Outdated Show resolved Hide resolved
@TristonianJones
Copy link
Collaborator Author

@jnthntatum PTAL

jnthntatum
jnthntatum previously approved these changes Aug 28, 2024
Copy link
Collaborator

@jnthntatum jnthntatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some optional suggestions for clarifications. otherwise LGTM

doc/langdef.md Outdated Show resolved Hide resolved
doc/langdef.md Outdated Show resolved Hide resolved
doc/langdef.md Outdated Show resolved Hide resolved
doc/langdef.md Outdated Show resolved Hide resolved
doc/langdef.md Outdated Show resolved Hide resolved
@TristonianJones TristonianJones merged commit 948c3a5 into google:master Aug 28, 2024
2 checks passed
@TristonianJones TristonianJones deleted the standard-function-docs branch August 28, 2024 21:06
@sergiitk
Copy link
Member

sergiitk commented Sep 5, 2024

Thanks for the useful documentation update, @TristonianJones!
One remark: I still found the old table format incredibly convenient as a concise overview of what methods are a part of the standard library. Would you consider bringing back the table at the top of the "Standard Definitions" sections, above the new in-detail docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants