-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test, simple: Don't parse the flag in init() #393
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
714b104
to
b1def3d
Compare
Doing the flag.Parse in init() erases the Go Test's builtin options such as -test.v. The right place to do that is TestMain and we even do that already. Remove the one in the init() function. === Before the change === Usage of ./simple.test: -check_server string path to command for check server -checked_only skip tests which skip type checking -eval_server string path to command for eval server -parse_server string path to command for parse server -pipe Use pipes instead of gRPC -pipe_base64 Use base64 encoded wire format proto in pipes (if disabled, use JSON). (default true) -pipe_pings Enable pinging pipe client to subprocess status. -server string path to binary for server when no phase-specific server defined -skip_check force skipping the check phase -skip_test value name(s) of tests to skip. can be set multiple times. to skip the following tests: f1/s1/t1, f1/s1/t2, f1/s2/*, f2/s3/t3, you give the arguments --skip_test=f1/s1/t1,t2;s2 --skip_test=f2/s3/t3 === After the change === Usage of ./simple.test: -check_server string path to command for check server -checked_only skip tests which skip type checking -eval_server string path to command for eval server -parse_server string path to command for parse server -pipe Use pipes instead of gRPC -pipe_base64 Use base64 encoded wire format proto in pipes (if disabled, use JSON). (default true) -pipe_pings Enable pinging pipe client to subprocess status. -server string path to binary for server when no phase-specific server defined -skip_check force skipping the check phase -skip_test value name(s) of tests to skip. can be set multiple times. to skip the following tests: f1/s1/t1, f1/s1/t2, f1/s2/*, f2/s3/t3, you give the arguments --skip_test=f1/s1/t1,t2;s2 --skip_test=f2/s3/t3 -test.bench regexp run only benchmarks matching regexp -test.benchmem print memory allocations for benchmarks -test.benchtime d run each benchmark for duration d or N times if `d` is of the form Nx (default 1s) -test.blockprofile file write a goroutine blocking profile to file -test.blockprofilerate rate set blocking profile rate (see runtime.SetBlockProfileRate) (default 1) -test.count n run tests and benchmarks n times (default 1) -test.coverprofile file write a coverage profile to file -test.cpu list comma-separated list of cpu counts to run each test with -test.cpuprofile file write a cpu profile to file -test.failfast do not start new tests after the first test failure -test.fullpath show full file names in error messages -test.fuzz regexp run the fuzz test matching regexp -test.fuzzcachedir string directory where interesting fuzzing inputs are stored (for use only by cmd/go) -test.fuzzminimizetime value time to spend minimizing a value after finding a failing input (default 1m0s) -test.fuzztime value time to spend fuzzing; default is to run indefinitely -test.fuzzworker coordinate with the parent process to fuzz random values (for use only by cmd/go) -test.gocoverdir string write coverage intermediate files to this directory -test.list regexp list tests, examples, and benchmarks matching regexp then exit -test.memprofile file write an allocation profile to file -test.memprofilerate rate set memory allocation profiling rate (see runtime.MemProfileRate) -test.mutexprofile string write a mutex contention profile to the named file after execution -test.mutexprofilefraction int if >= 0, calls runtime.SetMutexProfileFraction() (default 1) -test.outputdir dir write profiles to dir -test.paniconexit0 panic on call to os.Exit(0) -test.parallel n run at most n tests in parallel (default 4) -test.run regexp run only tests and examples matching regexp -test.short run smaller test suite to save time -test.shuffle string randomize the execution order of tests and benchmarks (default "off") -test.skip regexp do not list or run tests matching regexp -test.testlogfile file write test action log to file (for use only by cmd/go) -test.timeout d panic test binary after duration d (default 0, timeout disabled) -test.trace file write an execution trace to file -test.v verbose: print additional output Signed-off-by: Yutaro Hayakawa <yhayakawa3720@gmail.com>
b1def3d
to
70734d4
Compare
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my knowledge, we've stopped using this test driver within the other CEL repos, but have kept it present in the event it proves useful to others who are running conformance tests this way. This change seems okay to me.
Doing the flag.Parse in init() erases the Go Test's builtin options such as -test.v. The right place to do that is TestMain and we even do that already. Remove the one in the init() function.
=== Before the change ===
Usage of ./simple.test:
-check_server string
path to command for check server
-checked_only
skip tests which skip type checking
-eval_server string
path to command for eval server
-parse_server string
path to command for parse server
-pipe
Use pipes instead of gRPC
-pipe_base64
Use base64 encoded wire format proto in pipes (if disabled, use JSON). (default true)
-pipe_pings
Enable pinging pipe client to subprocess status.
-server string
path to binary for server when no phase-specific server defined
-skip_check
force skipping the check phase
-skip_test value
name(s) of tests to skip. can be set multiple times. to skip the following tests: f1/s1/t1, f1/s1/t2, f1/s2/*, f2/s3/t3, you give the arguments --skip_test=f1/s1/t1,t2;s2 --skip_test=f2/s3/t3
=== After the change ===
Usage of ./simple.test:
-check_server string
path to command for check server
-checked_only
skip tests which skip type checking
-eval_server string
path to command for eval server
-parse_server string
path to command for parse server
-pipe
Use pipes instead of gRPC
-pipe_base64
Use base64 encoded wire format proto in pipes (if disabled, use JSON). (default true)
-pipe_pings
Enable pinging pipe client to subprocess status.
-server string
path to binary for server when no phase-specific server defined
-skip_check
force skipping the check phase
-skip_test value
name(s) of tests to skip. can be set multiple times. to skip the following tests: f1/s1/t1, f1/s1/t2, f1/s2/*, f2/s3/t3, you give the arguments --skip_test=f1/s1/t1,t2;s2 --skip_test=f2/s3/t3
-test.bench regexp
run only benchmarks matching regexp
-test.benchmem
print memory allocations for benchmarks
-test.benchtime d
run each benchmark for duration d or N times if
d
is of the form Nx (default 1s)-test.blockprofile file
write a goroutine blocking profile to file
-test.blockprofilerate rate
set blocking profile rate (see runtime.SetBlockProfileRate) (default 1)
-test.count n
run tests and benchmarks n times (default 1)
-test.coverprofile file
write a coverage profile to file
-test.cpu list
comma-separated list of cpu counts to run each test with
-test.cpuprofile file
write a cpu profile to file
-test.failfast
do not start new tests after the first test failure
-test.fullpath
show full file names in error messages
-test.fuzz regexp
run the fuzz test matching regexp
-test.fuzzcachedir string
directory where interesting fuzzing inputs are stored (for use only by cmd/go)
-test.fuzzminimizetime value
time to spend minimizing a value after finding a failing input (default 1m0s)
-test.fuzztime value
time to spend fuzzing; default is to run indefinitely
-test.fuzzworker
coordinate with the parent process to fuzz random values (for use only by cmd/go)
-test.gocoverdir string
write coverage intermediate files to this directory
-test.list regexp
list tests, examples, and benchmarks matching regexp then exit
-test.memprofile file
write an allocation profile to file
-test.memprofilerate rate
set memory allocation profiling rate (see runtime.MemProfileRate)
-test.mutexprofile string
write a mutex contention profile to the named file after execution
-test.mutexprofilefraction int
if >= 0, calls runtime.SetMutexProfileFraction() (default 1)
-test.outputdir dir
write profiles to dir
-test.paniconexit0
panic on call to os.Exit(0)
-test.parallel n
run at most n tests in parallel (default 4)
-test.run regexp
run only tests and examples matching regexp
-test.short
run smaller test suite to save time
-test.shuffle string
randomize the execution order of tests and benchmarks (default "off")
-test.skip regexp
do not list or run tests matching regexp
-test.testlogfile file
write test action log to file (for use only by cmd/go)
-test.timeout d
panic test binary after duration d (default 0, timeout disabled)
-test.trace file
write an execution trace to file
-test.v
verbose: print additional output