Capture variables in tests and add logging. (#942)

google · May 31, 2022 · 3362d9e · 3362d9e
1 parent 5deb61e
commit 3362d9e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/fixchain/ratelimiter/limiter_test.go b/fixchain/ratelimiter/limiter_test.go
@@ -26,6 +26,7 @@ var testlimits = []int{1, 10, 50, 100, 1000}
 func TestRateLimiterSingleThreaded(t *testing.T) {
 	for i, limit := range testlimits {
 		t.Run(fmt.Sprintf("%d ops/s", limit), func(t *testing.T) {
+			i, limit := i, limit
 			t.Parallel()
 			l := NewLimiter(limit)
 
@@ -42,13 +43,15 @@ func TestRateLimiterSingleThreaded(t *testing.T) {
 			if qps > float64(limit)*1.01 {
 				t.Errorf("#%d: Too many operations per second. Expected ~%d, got %f", i, limit, qps)
 			}
+			log.Infof("#%d: Expected ~%d, got %f", i, limit, qps)
 		})
 	}
 }
 
 func TestRateLimiterGoroutines(t *testing.T) {
 	for i, limit := range testlimits {
 		t.Run(fmt.Sprintf("%d ops/s", limit), func(t *testing.T) {
+			i, limit := i, limit
 			t.Parallel()
 			l := NewLimiter(limit)
 
@@ -71,6 +74,7 @@ func TestRateLimiterGoroutines(t *testing.T) {
 			if qps > float64(limit)*1.01 {
 				t.Errorf("#%d: Too many operations per second. Expected ~%d, got %f", i, limit, qps)
 			}
+			log.Infof("#%d: Expected ~%d, got %f", i, limit, qps)
 		})
 	}
 }