Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lint exceptions and fix remaining issues #1065

Closed
5 tasks
mhutchinson opened this issue Apr 28, 2023 · 3 comments
Closed
5 tasks

Remove lint exceptions and fix remaining issues #1065

mhutchinson opened this issue Apr 28, 2023 · 3 comments
Labels
cleanup help wanted

Comments

@mhutchinson
Copy link
Contributor

https://github.com/google/certificate-transparency-go/blob/master/.golangci.yaml#L22 has an exclusion in place for errors that are discarded: https://golangci-lint.run/usage/false-positives/#exc0001

#1064 fixed a lot of similar errors, but these remaining ones are still to be fixed.

  • Remove the exception from .golangci.yaml
  • Run golangci-lint run
  • Fix the errors until the linter is happy
  • Submit PR
  • Enjoy the satisfaction of making the world a slightly better place
@silaselisha
Copy link
Contributor

@mhutchinson a polite request, I would like to work on this issue.

@roger2hk
Copy link
Contributor

@mhutchinson a polite request, I would like to work on this issue.

You're welcome to create pull requests and link to this issue.

@roger2hk
Copy link
Contributor

roger2hk commented May 8, 2024

Fixed in #1438.

@roger2hk roger2hk closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mhutchinson @roger2hk @silaselisha