Remove lint exceptions and fix remaining issues

[silaselisha]

• I have removed lint exception by commenting it out
• Fixed all remaining issues regarding golangci-lint exception

[silaselisha]

@roger2hk in the previous PR created to solve issues #1438 I realized it was failing as a result of a file of type *os.File getting closed twice and that's in file loglist_refresher_test.go on function createTempFile.

[AlCutter]

Thanks @silaselisha, I think we might want to "downgrade" some of these exits/panics - I think it's fine to do that in tests, but particularly in longer-lived server processes or client libraries it's likely better to just log these.

[roger2hk]

Error strings should not be capitalized (unless beginning with an exported name, a proper noun or an acronym) and should not end with punctuation. This is because error strings usually appear within other context before being printed to the user.

https://google.github.io/styleguide/go/decisions#error-strings

[silaselisha]

@AlCutter will it be fine for the recommended "downgrading" changes being part of this PR?

[silaselisha]

@roger2hk I'll look into it A.S.P. and also should I make changes to pieces of code that I didn't introduce but broke this rule https://google.github.io/styleguide/go/decisions#error-strings?

[roger2hk]

@roger2hk I'll look into it A.S.P. and also should I make changes to pieces of code that I didn't introduce but broke this rule https://google.github.io/styleguide/go/decisions#error-strings?

You should scope it to the lint changes. If you find some other error strings and would like to make changes, please open a separate pull request to address them.

[AlCutter]

@AlCutter will it be fine for the recommended "downgrading" changes being part of this PR?

@silaselisha yes please

[AlCutter]

/gcbrun

[AlCutter]

Hi Silas, many thanks for your PR & updates - I'm just going to make a couple of small tweaks and then I'll merge it for you.

[silaselisha]

@AlCutter Thank you, and I'm open for more contribution.

[AlCutter]

/gcbrun

[AlCutter]

/gcbrun

[AlCutter]

/gcbrun