Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509util: Break dependency from ctfe #921

Merged
merged 6 commits into from
May 4, 2022
Merged

x509util: Break dependency from ctfe #921

merged 6 commits into from
May 4, 2022

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented May 4, 2022

This change removes the dependency of x509util tests from ctfe/testonly
package introduced in #903.

There are 2 certificates copy-pasted between the two packages, but they don't
strictly need to match, and having them independent is a bigger advantage.

Checklist

@pav-kv pav-kv changed the title Break dependency from ctfe x509util: Break dependency from ctfe May 4, 2022
@pav-kv pav-kv requested review from mhutchinson and jiggoha May 4, 2022 15:15
@pav-kv
Copy link
Contributor Author

pav-kv commented May 4, 2022

This change is purely mechanical, it only removes the unneeded dependency. It does not change the exported surface, except removes some now unused constants in ctfe/testonly package.

May review commit-by-commit to follow the thoughts process, or the final state (in which case it can be harder to see the equivalence).

@pav-kv pav-kv marked this pull request as ready for review May 4, 2022 15:16
@pav-kv pav-kv merged commit 88227ce into google:master May 4, 2022
@pav-kv pav-kv deleted the break_dependency_from_ctfe branch May 4, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants