This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Golang: Initialize http.Client if passed nil in client.New #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
gdbelvin
added a commit
to gdbelvin/certificate-transparency
that referenced
this pull request
Jul 14, 2016
* upstream/master: (23 commits) Check for HTTP status 200 in fetchAndParse. Run everything through gofmt. Tweak the imports to make goimports happier. Initialize client if passed nil (google#1265) Have the caller supply the *http.Client used in logclient.go. Review fixes Use ASN1 lib to transform TLS encoded list into a Octet String Move SCTListLen Check to beginning Rework patch Add support for serializing SCT Lists Get rid of the Java MerkleLeafType enum. Add a missing entry to the .gitignore file. Get rid of the TLSSerializer class. Make the low-level serialization functions stand-alone ones in a namespace rather than members of a class. 6962-bis: Implement OID parsing/serialization. Do not use std::move in "return" statements. Improve stats comments and add additional inc. Add additonal stats to outer FixAndLog wrapper. [golang] Merkle verifier (google#1161) Ignore clang warnings due to unused stuff caused by glog (google#1253) Remove a few unnecessary uses of std::move. ...
gdbelvin
pushed a commit
to gdbelvin/certificate-transparency
that referenced
this pull request
Jul 18, 2016
gdbelvin
added a commit
to gdbelvin/certificate-transparency
that referenced
this pull request
Jul 18, 2016
* upstream/master: (25 commits) Check for HTTP status 200 in fetchAndParse. Run everything through gofmt. Tweak the imports to make goimports happier. Initialize client if passed nil (google#1265) Have the caller supply the *http.Client used in logclient.go. Review fixes Use ASN1 lib to transform TLS encoded list into a Octet String Move SCTListLen Check to beginning Rework patch Add support for serializing SCT Lists Get rid of the Java MerkleLeafType enum. Add a missing entry to the .gitignore file. Get rid of the TLSSerializer class. Make the low-level serialization functions stand-alone ones in a namespace rather than members of a class. 6962-bis: Implement OID parsing/serialization. Do not use std::move in "return" statements. Improve stats comments and add additional inc. Add additonal stats to outer FixAndLog wrapper. [golang] Merkle verifier (google#1161) Ignore clang warnings due to unused stuff caused by glog (google#1253) Remove a few unnecessary uses of std::move. ...
gdbelvin
added a commit
to gdbelvin/certificate-transparency
that referenced
this pull request
Jul 18, 2016
* upstream/master: (25 commits) Check for HTTP status 200 in fetchAndParse. Run everything through gofmt. Tweak the imports to make goimports happier. Initialize client if passed nil (google#1265) Have the caller supply the *http.Client used in logclient.go. Review fixes Use ASN1 lib to transform TLS encoded list into a Octet String Move SCTListLen Check to beginning Rework patch Add support for serializing SCT Lists Get rid of the Java MerkleLeafType enum. Add a missing entry to the .gitignore file. Get rid of the TLSSerializer class. Make the low-level serialization functions stand-alone ones in a namespace rather than members of a class. 6962-bis: Implement OID parsing/serialization. Do not use std::move in "return" statements. Improve stats comments and add additional inc. Add additonal stats to outer FixAndLog wrapper. [golang] Merkle verifier (google#1161) Ignore clang warnings due to unused stuff caused by glog (google#1253) Remove a few unnecessary uses of std::move. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
http.Clientpassed togo/client.Newis nil initialize it before passingclient.LogClientback to the user (general Golang stdlib behavior as far as I can tell).