This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
go: partial implementation of CTv2 #1346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daviddrysdale I'll wait for the first 2 commits to be reviewed there first, if that's OK with you? |
Some TLS types have size fields like: opaque nonEmptyType<2..4> nonEmptyType values<0..8> where the outer holder can explicitly be empty, but the element type is always >0 in size. Add a test case to check that this is processed correctly.
To allow for SET OF ANY / SEQUENCE OF ANY, don't check the element type tags for []asn1.RawValue.
- Go types for all TLS types - Go types for all JSON request/response structures - JSON encoding methods for TransItem type
|
Moved to google/certificate-transparency-go#1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 2 commits (in go/tls, go/asn1) are some encoding library fixes/tests that turned up along the way.
The final 3 commits are the CTv2 work: