Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Fix build issues with LibreSSL #1364

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix build issues with LibreSSL #1364

wants to merge 3 commits into from

Conversation

Sp1l
Copy link

@Sp1l Sp1l commented Feb 11, 2017

  1. Fix CMS detection
  2. Fix OPENSSL_VERSION_NUMBER checks

Sp1l and others added 2 commits February 11, 2017 21:18
@Sp1l
Fix build issue with LibreSSL
727544f 
LibreSSL defines OPENSSL_VERSION_NUMBER as 0x20000000L though being forked from 1.0.1f
LibreSSL defines LIBRESSL_VERSION_NUMBER
@Sp1l
Fix CMS detection for LibreSSL
4ae8963 
  - Neither BoringSSL nor LibreSSL support CMS
  - Add test to detect LibreSSL
  - Create new knob for OPENSSL_NO_CMS
  - Use OPENSSL_NO_CMS knob for disabling cms_verifier building
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Sp1l added a commit to HardenedBSD/hardenedbsd-ports that referenced this pull request Feb 11, 2017
@Sp1l
HBSD: security/certificate-transparency: Fix build with LibreSSL
20eccfb 
Fixes #11

See also google/certificate-transparency#1364

Signed-off-by: Bernard Spil <bernard.spil@hardenedbsd.org>
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@eranmes eranmes requested a review from pphaneuf February 13, 2017 16:09
@eranmes
Copy link
Contributor

eranmes commented Feb 13, 2017

Pierre has kindly agreed to take a look.

uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Mar 26, 2017
security/certificate-transparency: Fix build issues with LibreSSL
4ce7ddf 
  - Fix OPENSSL_VERSION_NUMBER checks
  - Fix LibreSSL detection
  - Modify CMS disabling to BoringSSL and LibreSSL

PR:		217013
Obtained from:	google/certificate-transparency#1364


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@436952 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Mar 26, 2017
@Sp1l
security/certificate-transparency: Fix build issues with LibreSSL
75e94eb 
  - Fix OPENSSL_VERSION_NUMBER checks
  - Fix LibreSSL detection
  - Modify CMS disabling to BoringSSL and LibreSSL

PR:		217013
Obtained from:	google/certificate-transparency#1364
@digitalist
Copy link

digitalist commented Feb 24, 2018 •
edited
Loading

how are we doing here? It's borken-borken for TrueOS, since it uses LibreSSL

@pphaneuf pphaneuf removed their request for review May 24, 2022 10:50
@pphaneuf pphaneuf removed their assignment May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Sp1l @googlebot @eranmes @digitalist @thuanversace @donnakids2018 @pphaneuf