Remove the arguments usage check. Users never really liked it, and …

…the primary motivation for creating it is a non-issue now that 6a40212 is submitted. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=116147157
google · Mar 2, 2016 · 3734b26 · 3734b26
1 parent a5166e4
commit 3734b26
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 143 deletions.
diff --git a/src/com/google/javascript/jscomp/DefaultPassConfig.java b/src/com/google/javascript/jscomp/DefaultPassConfig.java
@@ -31,7 +31,6 @@
 import com.google.javascript.jscomp.ExtractPrototypeMemberDeclarations.Pattern;
 import com.google.javascript.jscomp.NodeTraversal.Callback;
 import com.google.javascript.jscomp.PassFactory.HotSwapPassFactory;
-import com.google.javascript.jscomp.lint.CheckArguments;
 import com.google.javascript.jscomp.lint.CheckDuplicateCase;
 import com.google.javascript.jscomp.lint.CheckEmptyStatements;
 import com.google.javascript.jscomp.lint.CheckEnums;
@@ -1558,7 +1557,6 @@ protected HotSwapCompilerPass create(AbstractCompiler compiler) {
     @Override
     protected HotSwapCompilerPass create(AbstractCompiler compiler) {
       ImmutableList.Builder<Callback> callbacks = ImmutableList.<Callback>builder()
-          .add(new CheckArguments(compiler))
           .add(new CheckEmptyStatements(compiler))
           .add(new CheckEnums(compiler))
           .add(new CheckInterfaces(compiler))

diff --git a/src/com/google/javascript/jscomp/DiagnosticGroups.java b/src/com/google/javascript/jscomp/DiagnosticGroups.java
@@ -20,7 +20,6 @@
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
-import com.google.javascript.jscomp.lint.CheckArguments;
 import com.google.javascript.jscomp.lint.CheckDuplicateCase;
 import com.google.javascript.jscomp.lint.CheckEmptyStatements;
 import com.google.javascript.jscomp.lint.CheckEnums;
@@ -468,7 +467,6 @@ public DiagnosticGroup forName(String name) {
   // provide optional suggestions.
   public static final DiagnosticGroup LINT_CHECKS =
       DiagnosticGroups.registerGroup("lintChecks", // undocumented
-          CheckArguments.BAD_ARGUMENTS_USAGE,
           CheckEmptyStatements.USELESS_EMPTY_STATEMENT,
           CheckEnums.COMPUTED_PROP_NAME_IN_ENUM,
           CheckEnums.DUPLICATE_ENUM_VALUE,

diff --git a/src/com/google/javascript/jscomp/LintPassConfig.java b/src/com/google/javascript/jscomp/LintPassConfig.java
@@ -17,7 +17,6 @@
 
 import com.google.common.collect.ImmutableList;
 import com.google.javascript.jscomp.NodeTraversal.Callback;
-import com.google.javascript.jscomp.lint.CheckArguments;
 import com.google.javascript.jscomp.lint.CheckDuplicateCase;
 import com.google.javascript.jscomp.lint.CheckEmptyStatements;
 import com.google.javascript.jscomp.lint.CheckEnums;
@@ -107,7 +106,6 @@ protected CompilerPass create(AbstractCompiler compiler) {
           return new CombinedCompilerPass(
               compiler,
               ImmutableList.<Callback>of(
-                  new CheckArguments(compiler),
                   new CheckDuplicateCase(compiler),
                   new CheckEmptyStatements(compiler),
                   new CheckEnums(compiler),

diff --git a/src/com/google/javascript/jscomp/lint/CheckArguments.java b/src/com/google/javascript/jscomp/lint/CheckArguments.java
diff --git a/test/com/google/javascript/jscomp/lint/CheckArgumentsTest.java b/test/com/google/javascript/jscomp/lint/CheckArgumentsTest.java