Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Commit

Permalink
Fix comments and a typo.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 276327600
  • Loading branch information
manugarg committed Oct 23, 2019
1 parent c38d6d6 commit 102b313
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 13 deletions.
5 changes: 3 additions & 2 deletions metrics/map.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,9 @@ func (m *Map) String() string {

// ParseMapFromString parses a map value string into a map object.
// Note that the values are always parsed as floats, so even a map with integer
// values will become a float map. For example:
// "map:code 200:10123 404:21" will be parsed as:
// values will become a float map.
// For example:
// "map:code,200:10123,404:21" will be parsed as:
// "map:code 200:10123.000 404:21.000".
func ParseMapFromString(mapValue string) (*Map, error) {
tokens := strings.Split(mapValue, ",")
Expand Down
10 changes: 9 additions & 1 deletion rds/server/gcp/proto/config.proto
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Configuration proto for GCE targets.
// Configuration proto for GCP provider.
// Example config:
// {
// project: 'test-project-id'
Expand All @@ -12,6 +12,14 @@
// name: "lame-duck-targets"
// }
// }
//
// # Pub/Sub messages from the topic lame-duck-targets.
// pubsub_messages {
// subscription {
// name: "lame-duck-targets-{{.hostname}}"
// topic_name: "lame-duck-targets"
// }
// }
// }
syntax = "proto2";

Expand Down
28 changes: 18 additions & 10 deletions rds/server/kubernetes/proto/config.proto
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
// Configuration proto for GCE targets.
// Example config:
// {
// project: 'test-project-id'
// Configuration proto for Kubernetes provider.
//
// # GCE instances
// gce_instances {}
// Example provider config:
// {
// pods {}
// }
//
// # RTC variables from the config lame-duck-targets, re-evaluated every 10s.
// rtc_variables {
// rtc_config {
// name: "lame-duck-targets"
// In probe config:
// probe {
// targets{
// rds_targets {
// resource_path: "k8s://pods"
// filter {
// key: "namespace"
// value: "default"
// }
// filter {
// key: "name"
// value: "cloudprober.*"
// }
// }
// }
// }
Expand Down

0 comments on commit 102b313

Please sign in to comment.