This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Add a way to export gauge metrics and other changes. #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
= Introduce the ability to transform metrics before exporting. Currently implementing two types of transformations: - Add "failure" metric to EventMetrics. - Convert cumulative metrics to gauge metrics. = To calculate gauge metrics from cumulative metrics, we keep a "last-value" cache of EventMetrics by a key that consists of metric names and label keys and values. We subtract last EventMetrics from the new EventMetrics and export the results. = This requires implementing subtract logic through the metrics stack: from EventMetrics to individual value types. We need to also take into account that metrics may be reset. Ref: #494 PiperOrigin-RevId: 377179096
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the ability to transform metrics before exporting. Currently implementing two types of transformations:
To calculate gauge metrics from cumulative metrics, we keep a "last-value" cache of EventMetrics by a key that consists of metric names and label keys and values. We subtract last EventMetrics from the new EventMetrics and export the results.
This requires implementing subtract logic through the metrics stack: from EventMetrics to individual value types. We need to also take into account that metrics may be reset.
Ref: #494
PiperOrigin-RevId: 377179096