-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ja: Translate Chapter 50, Send and Sync #1161
Conversation
@@ -16663,16 +16669,23 @@ msgid "" | |||
"contain `Send` and `Sync` types. You can also implement them manually when " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentenses around here were difficult for me to figure out what "they", and "them" are. Possibly I might send a request for clarifications for original English content if I have some time and energy :) Probably original authors might be able to autocomplete them in their brain, but for those who are begineers, like me, often it would be nice we have concrete descriptions rather than "it", "this", "them", and "they".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random & premature comments
I need to run for now
I may come back again to correct my comments
Kudos to @HidenoriKobayashi for giving me concrete and helpful suggestions! Thank you. @keiichiw or @chikoski, when you have some time, could you skim thru or merge the MR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was on vacation. Here are my review comments.
Hi, @keiichiw thanks for providing concrete feedback with reference, which helped me a lot to learn the concepts behind the scenes! I have incorporated your suggestions. Could you reveiw it once again? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for my late response. The translation looks good overall. I put some comments for minor editorial things. Please take a look at it.
Hi @chikoski, thanks for concrete suggestions. They're generally helpful and applicable to my future translations, too :) I've accepted your suggestions. Could someone merge it if it looks good? Thank you! |
Hi, JA translation folks (#652), here's a MR for the chapter "Send and Sync". This chapter is particularly interesting and contains very rust-specific concepts which seems unfamiliar to me. Any feedback and suggestions are welcome :)