Update to mdbook-i18n-helpers 0.3.0 #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version has much improved support for the translation of code blocks. See google/mdbook-i18n-helpers#95 for details. Most PO files won’t need any update since most of them don’t translate the comments in the code blocks. Those that do, can run `mdbook-i18n-normalize` when they feel like it.
This was referenced Nov 9, 2023
Closed
Closed
Open
henrif75
approved these changes
Nov 9, 2023
mgeisler
added a commit
that referenced
this pull request
Nov 11, 2023
With #1460 merged, we took away the possibility of translating variable and struct names in the code snippets. This broke the Brazilian Portuguese translation because it _does_ translate those things quite frequently! This PR reverts the translations back to the English original. I tried to also update the surrounding messages to use the English words: so when a slide talked about a `nome` variable before, it now uses `name` instead. We don’t have automated tests for this, so I hope I did this correctly.
mgeisler
added a commit
that referenced
this pull request
Nov 13, 2023
With #1460 merged, we took away the possibility of translating variable, struct, and function names in the code snippets. This broke the Brazilian Portuguese translation because it _does_ translate those things quite frequently! This PR reverts the translations back to the English original. I tried to also update the surrounding messages to use the English words: so when a slide talked about a `nome` variable before, it now uses `name` instead. We don’t have automated tests for this, so I hope I did this correctly.
mgeisler
added a commit
that referenced
this pull request
Nov 16, 2023
This splits translated code blocks into individual messages, thus preserving the translation after #1460. This removes ~6k unnecessary lines from the PO file.
mgeisler
pushed a commit
that referenced
this pull request
Dec 7, 2023
rickyclarkson
pushed a commit
to rickyclarkson/comprehensive-rust
that referenced
this pull request
Dec 11, 2023
…1482) Hello, JA translation team! (google#652) As part of google#1460, I normalized ja.po using mdbook-i18n-normalize 0.3.0. Steps taken: `mdbook-i18n-normalize`. I'm open to any feedback or suggestions. Thank you in advance!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version has much improved support for the translation of code blocks. See google/mdbook-i18n-helpers#95 for details.
Most PO files won’t need any update since most of them don’t translate the comments in the code blocks. Those that do, can run
mdbook-i18n-normalizewhen they feel like it.