Various small fixes #1556

marshallpierce · 2023-12-05T18:56:13Z

Plus one more substantial comment on casting.

marshallpierce · 2023-12-05T18:57:37Z

src/borrowing/shared.md

@@ -62,4 +62,4 @@ Notes on stack returns:

 </details>

-[Playground]: https://play.rust-lang.org/
+[Playground]: https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=0cb13be1c05d7e3446686ad9947c4671


playground share link for release mode on the above code

Just in case you haven't thought of it: we don't have a good way to maintaining these links as we modify the code. So I've been resisting adding them so far.

But let's see how it goes: perhaps we won't ever modify this and then the link is great 😄

This was the only place that I found the playground useful, which is why I bothered... but yes, the maintenance concern does make me uneasy. If there was a safe way to avoid spamming playground with these snippets (content addressable storage style, perhaps) at each build, maybe we could automatically populate these links.

maybe we could automatically populate these links.

It's possible to embed the code directly into the link: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&code=fn+main%28%29+%7B%0A++++let+x+%3D+42%3B%0A%7D

So one could in principle (assuming the server accepts very long URLs) make a mdbook plugin which constructs such URLs for us automatically.

src/memory-management/exercise.rs

src/methods-and-traits/methods.md

src/slices-and-lifetimes/lifetime-elision.md

src/slices-and-lifetimes/slices.md

src/std-traits/default.md

src/std-traits/from-and-into.md

src/user-defined-types/enums.md

src/user-defined-types/named-structs.md

marshallpierce · 2023-12-05T19:02:11Z

src/std-traits/casting.md

+
+For infallible casts (e.g. `u32` to `u64`), prefer using `From` or `Into` over `as`
+to confirm that the cast is in fact infallible. For fallible casts, `TryFrom` and `TryInto` are available when you want to handle casts that fit differently from those that don't.
+


This was the one bit of content that seemed to be missing detail to me, so I fleshed it out with guidance derived from what my team has found to work well doing a fair bit of bit wrangling.

Side note: I expected dprint fmt to wrap this, but it didn't 🤷

Side note: I expected dprint fmt to wrap this, but it didn't 🤷

This is because we've been excluding the src/ directory until now. I have #1157 up for this, but I was waiting for the v2 rewrite to land first. I will re-fresh that PR now and then we can have everything consistent.

djmitche

Great fixes - thank you!

djmitche · 2023-12-05T19:32:34Z

src/pattern-matching/let-control-flow.md

@@ -36,7 +36,7 @@ fn main() {
 For the common case of matching a pattern and returning from the function, use
 [`let
 else`](https://doc.rust-lang.org/rust-by-example/flow_control/let_else.html).
-The "else" case must diverge (`return`, `break`, or panic - anything but
+The "else" case must evaluate to the same type as the `if` block, or diverge (`return`, `break`, or panic - anything but


I don't think this is true for let else.

Oh, right, except this one :)

Ah, I mangled up the if let and let else sections; I'll revert this. Maybe let else should get its own section header?

djmitche · 2023-12-05T19:32:58Z

src/running-the-course/course-structure.md

 The days are fast paced and we cover a lot of ground!

 {{%course outline Fundamentals}}

 ## Deep Dives

-In addition to the 3-day class on Rust Fundamentals, we cover some more
+In addition to the 4-day class on Rust Fundamentals, we cover some more


I missed a lot of spots for 3 -> 4!

src/slices-and-lifetimes/lifetime-elision.md

djmitche · 2023-12-05T19:34:05Z

src/std-traits/casting.md

+
+For infallible casts (e.g. `u32` to `u64`), prefer using `From` or `Into` over `as`
+to confirm that the cast is in fact infallible. For fallible casts, `TryFrom` and `TryInto` are available when you want to handle casts that fit differently from those that don't.
+


djmitche

(for the let-else comment)

djmitche

Sorry, I'm struggling with the GH UI today :)

Plus one more substantial comment on casting.

marshallpierce · 2023-12-05T23:05:02Z

src/pattern-matching/let-control-flow.md

@@ -33,6 +33,7 @@ fn main() {
 }
 ```

+# `let else` expressions 


Matches # if let expressions above -- maybe overkill?

No, makes sense. I didn't realize that was missing!

djmitche · 2023-12-05T23:06:28Z

src/pattern-matching/let-control-flow.md

@@ -33,6 +33,7 @@ fn main() {
 }
 ```

+# `let else` expressions 


No, makes sense. I didn't realize that was missing!

marshallpierce force-pushed the mp/small-fixes branch from 7c92d81 to ae10c46 Compare December 5, 2023 19:02

marshallpierce commented Dec 5, 2023

View reviewed changes

marshallpierce marked this pull request as ready for review December 5, 2023 19:06

marshallpierce requested a review from mgeisler December 5, 2023 19:06

djmitche approved these changes Dec 5, 2023

View reviewed changes

djmitche reviewed Dec 5, 2023

View reviewed changes

djmitche requested changes Dec 5, 2023

View reviewed changes

Various small fixes

033ee0b

Plus one more substantial comment on casting.

marshallpierce force-pushed the mp/small-fixes branch from ae10c46 to 033ee0b Compare December 5, 2023 23:02

marshallpierce commented Dec 5, 2023

View reviewed changes

djmitche approved these changes Dec 5, 2023

View reviewed changes

djmitche merged commit 6c5061b into google:main Dec 5, 2023
31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various small fixes #1556

Various small fixes #1556

marshallpierce commented Dec 5, 2023

marshallpierce Dec 5, 2023

mgeisler Dec 6, 2023

marshallpierce Dec 7, 2023

mgeisler Jan 5, 2024

marshallpierce Dec 5, 2023

djmitche Dec 5, 2023

mgeisler Dec 6, 2023

djmitche left a comment

djmitche Dec 5, 2023

djmitche Dec 5, 2023

marshallpierce Dec 5, 2023

djmitche Dec 5, 2023

djmitche Dec 5, 2023

djmitche left a comment

djmitche left a comment

marshallpierce Dec 5, 2023

djmitche Dec 5, 2023

djmitche Dec 5, 2023


		For infallible casts (e.g. `u32` to `u64`), prefer using `From` or `Into` over `as`
		to confirm that the cast is in fact infallible. For fallible casts, `TryFrom` and `TryInto` are available when you want to handle casts that fit differently from those that don't.

Various small fixes #1556

Various small fixes #1556

Conversation

marshallpierce commented Dec 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djmitche left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djmitche left a comment

Choose a reason for hiding this comment

djmitche left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment