Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: New CR2 translations with line numbers removed #1764

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented Jan 25, 2024

Publishes the new translations for CR2 (originally from zh-CN-cr2) #1463 which were previously reviewed.
It also removes line numbers (#1753)
#324

You can skim this PR with the GitHub CLI:

gh pr diff 1764 | bat -l patch

@AgainstEntropy
Copy link
Collaborator

Publishes the new translations for CR2 (originally from zh-CN-cr2) #1463 which were previously reviewed. It also removes line numbers (#1753) #324

You can skim this PR with the GitHub CLI:

gh pr diff 1764 | bat -l patch

Hi @henrif75, thanks for your effort!

Since these translations have been reviewed before, I can directly approve the merge (after a rough re-review), right?

Then we can continue with the rest of the zh-CN translation on top of the merge result.

@henrif75
Copy link
Collaborator Author

Publishes the new translations for CR2 (originally from zh-CN-cr2) #1463 which were previously reviewed. It also removes line numbers (#1753) #324
You can skim this PR with the GitHub CLI:

gh pr diff 1764 | bat -l patch

Hi @henrif75, thanks for your effort!

Since these translations have been reviewed before, I can directly approve the merge (after a rough re-review), right?

Then we can continue with the rest of the zh-CN translation on top of the merge result.

That's right! Thanks @AgainstEntropy

Copy link
Collaborator

@AgainstEntropy AgainstEntropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge previously reviewed tranlations (#1463)

@henrif75 henrif75 merged commit 72cdaaa into google:main Jan 27, 2024
33 checks passed
@henrif75
Copy link
Collaborator Author

Thanks @AgainstEntropy !

@henrif75 henrif75 deleted the zh-CN-henrif branch January 27, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants