es: Course length mistake #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit course length from 3 days to 4 which is actually the total length
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
The original english text does not mention the length. I would recommend to just rearrange the translation to match the same. Also, you need to sign the CLA as mentioned above. |
|
@salvamunoz, can you take out the mentioning of days like @deavid suggests? Then we can merge this! |
mgeisler
reviewed
Aug 21, 2024
|
Yes, that's correct Spanish
…On Wed, 21 Aug 2024, 07:29 Martin Geisler, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In po/es.po
<#2043 (comment)>
:
> @@ -1217,7 +1217,7 @@ msgid ""
"course covers the full spectrum of Rust, from basic syntax to advanced "
"topics like generics and error handling."
msgstr ""
-"Este es un curso de Rust de tres días que ha desarrollado el equipo de "
+"Este es un curso de Rust de cuatro días que ha desarrollado el equipo de "
@salvamunoz <https://github.com/salvamunoz> and @deavid
<https://github.com/deavid>, is this correct Spanish?
⬇️ Suggested change
-"Este es un curso de Rust de cuatro días que ha desarrollado el equipo de "
+"Este es un curso de Rust que ha desarrollado el equipo de "
—
Reply to this email directly, view it on GitHub
<#2043 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFJRLRRPIAZE3QTYBX5MDZSQXVFAVCNFSM6AAAAABHBYEUCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBZHAZTKMZUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks a lot! 🎉 |
mgeisler
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit course length from 3 days to 4 which is actually the total length