Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar: First Stage: Initial 5000 Lines Translated #2322

Merged
merged 50 commits into from
Oct 17, 2024
Merged

ar: First Stage: Initial 5000 Lines Translated #2322

merged 50 commits into from
Oct 17, 2024

Conversation

younies
Copy link
Member

@younies younies commented Aug 26, 2024 •
edited
Loading

Description

This pull request represents the first stage of translating the ar.po file into Arabic. The initial 5000 lines of the file have been translated.

@younies younies changed the title Arabic translation First Stage of Arabic Translation: Initial 5000 Lines of ar.po Translated Aug 26, 2024
@younies younies requested a review from SalehAly August 26, 2024 11:34
SalehAly
SalehAly reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@SalehAly SalehAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CL is too big, I will review it in chunks because some changes can propagate into other translations.

I reviewed the first 1K lines.

po/ar.po Outdated Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
@younies younies requested a review from SalehAly August 27, 2024 10:56
SalehAly
SalehAly reviewed Aug 27, 2024
View reviewed changes
po/ar.po Outdated Show resolved Hide resolved
@SalehAly SalehAly self-requested a review August 27, 2024 11:46
SalehAly
SalehAly reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@SalehAly SalehAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done from 1000 to 1500.

po/ar.po Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
@mgeisler mgeisler changed the title First Stage of Arabic Translation: Initial 5000 Lines of ar.po Translated ar: First Stage: Initial 5000 Lines Translated Aug 27, 2024
@mgeisler
Copy link
Collaborator

Very small point: I renamed the PR title to ar: ... — this simply serves to give the resulting commit a uniform look.

SalehAly
SalehAly reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@SalehAly SalehAly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed till 2K

po/ar.po Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Outdated Show resolved Hide resolved
po/ar.po Show resolved Hide resolved
@younies younies force-pushed the arabic-translation branch 2 times, most recently from 14d8888 to 16a7e0f Compare August 29, 2024 11:55
younies and others added 5 commits August 29, 2024 13:57
@younies @SalehAly
Update po/ar.po
029a553 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
7801e55 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
03d0bc9 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
2688483 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
cfe0727 
Co-authored-by: Aly Saleh <alysaleh@google.com>
younies and others added 26 commits October 15, 2024 15:46
@younies @SalehAly
Update po/ar.po
c7cbdb2 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
1d1e8de 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
3baf89a 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
53ef89d 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
f0935b5 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
f47e1c4 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
27f1486 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
3b3d2cc 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
b216ac7 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
a8fa910 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
1b6f888 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies
Update po/ar.po
505b1da
@younies
Update po/ar.po
ed73926
@younies
Update po/ar.po
d100e2b
@younies @SalehAly
Update po/ar.po
566824a 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
f5c655c 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
c9837dd 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
9d88a60 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
1577c98 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
0a88a33 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies
Update po/ar.po
27858e9
@younies @SalehAly
Update po/ar.po
b5d80f1 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
ead0b56 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
5b8f9e8 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies @SalehAly
Update po/ar.po
c138512 
Co-authored-by: Aly Saleh <alysaleh@google.com>
@younies
Update po/ar.po
aec0d08
@younies younies requested a review from SalehAly October 15, 2024 15:39
@younies younies merged commit 2552776 into main Oct 17, 2024
38 checks passed
@younies younies deleted the arabic-translation branch October 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeisler mgeisler mgeisler left review comments

@HidenoriKobayashi HidenoriKobayashi HidenoriKobayashi left review comments

@SalehAly SalehAly SalehAly approved these changes

Assignees
No one assigned
Labels
translation/ar translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@younies @mgeisler @SalehAly @HidenoriKobayashi