Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Welcome Day 2 and Day 3 #2448

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

quynhpha2hht
Copy link

@quynhpha2hht quynhpha2hht commented Oct 23, 2024

Translate Welcome to Day 2 and Welcome to Day 3 to Vietnamese.

Copy link

google-cla bot commented Oct 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is the best suggestion or not. Hope to hear your thoughts soon!

po/vi.po Outdated

#: src/welcome-day-3.md
msgid ""
"Memory management, lifetimes, and the borrow checker: how Rust ensures "
"memory safety."
msgstr ""
"Quản lý bộ nhớ, vòng đời (lifetimes), và trình kiểm tra mượn (the borrow "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"quá trình kiểm mượn" should be better than "trình kiểm tra mượn". Sounds a bit rough with trình kiểm tra mượn

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds better than the original.

po/vi.po Outdated

#: src/welcome-day-3.md
msgid "Today, we will cover:"
msgstr ""
msgstr "Chủ đề chúng ta sẽ học là:"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Chủ đề hôm nay chúng ta sẽ học là" or "Chủ đề chúng ta sẽ học hôm nay là:" might be "more" closely translated. If you don't like it I can still resolve it btw.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I've also changed the sentence to make it more natural.

@qu-ngx
Copy link
Collaborator

qu-ngx commented Oct 27, 2024

@quynhpha2hht Make sure to sign your Google CLA as well so I can approve it once all the changes are made. I cannot merge your code without it!

Change some Vietnamese translation sentences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants