Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust before setting up the cache #2460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mgeisler
Copy link
Collaborator

@mgeisler mgeisler commented Nov 1, 2024

The cache is keyed on the Rust version used, so we should update Rust before setting up the cache.

This is a small update to #2449.

The cache is keyed on the Rust version used, so we should update Rust
before setting up the cache.

This is a small update to #2449.
@mgeisler mgeisler requested a review from qwandor November 1, 2024 07:56
@mgeisler
Copy link
Collaborator Author

mgeisler commented Nov 1, 2024

Looking a bit more at rustup, I wonder if we should start using a toolchain file: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file.

I've never had to do this before, but it seems like it could simplify our setup in a few places? It could perhaps make

matrix:
include:
- directory: src/bare-metal/alloc-example
target: aarch64-unknown-none
- directory: src/bare-metal/aps/examples
target: aarch64-unknown-none
- directory: src/bare-metal/microcontrollers/examples
target: thumbv7em-none-eabihf
- directory: src/exercises/bare-metal/compass
target: thumbv7em-none-eabihf
- directory: src/exercises/bare-metal/rtc
target: aarch64-unknown-none

unnecessary (by moving this into separate toolchain files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant