Fix zero size reads for Engine Socket. #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InputStream explicitly allows zero size reads without attempting IO or blocking. We do this correctly for the fd-socket but missed it for the Engine socket. Not clear whether zero sized read should trigger a TLS handshake, but it always has on Android so keeping it that way. Bug manifested as a flaky test hang. Fixed the test to explicitly check corner cases and removed un-needed concurrency.
tweksteen
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputStream explicitly allows zero size reads without blocking or attempting IO. We do this correctly for the fd-socket but missed it for the Engine socket.
Not clear whether zero sized read should trigger a TLS handshake, but it always has on Android so keeping it that way.
Bug manifested as a flaky test hang. Fixed the test to explicitly check corner cases and removed un-needed concurrency.