repositories: pinning platforms to latest version #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Bazel versions from 5.1.0 and older, there was a change [1] which prevents copybara from compiling on Apple Silicon by default. The solution recommended in [2] was to pin `platforms` repository to a newer version where the constraints value for CPP toolchain could be correctly resolved. Without this change, we would need to use Bazel 5.0.0 or older to compile copybara successfully on Apple Silicon. [1]: bazelbuild/bazel#14844 [2]: bazelbuild/bazel#15175
|
cc: @mikelalcon Additional request: I would like to add a |
|
Hi, sure, that sg. Not sure how it will work since we might have different Bazel versions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Bazel versions from 5.1.0 and older, there was a change 1 which
prevents copybara from compiling on Apple Silicon by default.
The solution recommended in 2 was to pin
platformsrepository to anewer version where the constraints value for CPP toolchain could be
correctly resolved.
Without this change, we would need to use Bazel 5.0.0 or older to
compile copybara successfully on Apple Silicon.