Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allocator bump in printf string allocation #374

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

gchatelet
Copy link
Collaborator

@gchatelet gchatelet commented Dec 10, 2024

vsnprintf returns the number of printed characters excluding the written \0. This leads to the next value overwriting the last \0, which in turn can print spurious characters to the output.

Fixes #373.

@gchatelet gchatelet requested a review from Mizux December 10, 2024 10:38
@gchatelet gchatelet force-pushed the fix_overwrite_backslash_zero_in_list_cpu_features branch 3 times, most recently from c0f0437 to a2b9437 Compare December 16, 2024 10:06
@Mizux
Copy link
Collaborator

Mizux commented Dec 16, 2024

All jobs failing are using

Runner Image Provisioner
2.0.385.1

while eveything pass on my PR using:

Runner Image Provisioner
2.0.404.1

@Mizux
Copy link
Collaborator

Mizux commented Dec 16, 2024

Managed to reproduce it locally, will try to bump QEMU version see if it help for ppc ...

@gchatelet gchatelet force-pushed the fix_overwrite_backslash_zero_in_list_cpu_features branch from a2b9437 to 3a989ba Compare December 17, 2024 12:58
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchatelet gchatelet merged commit 65b952a into main Dec 17, 2024
58 checks passed
@gchatelet gchatelet deleted the fix_overwrite_backslash_zero_in_list_cpu_features branch December 17, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants