Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bazel] Use a macro instead of @platforms//os:windows #379

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[bazel] Use a macro instead of @platforms//os:windows #379

merged 1 commit into from
Dec 17, 2024

Conversation

gchatelet
Copy link
Collaborator

No description provided.

@gchatelet gchatelet self-assigned this Dec 17, 2024
@gchatelet gchatelet added misc non user facing: internal, cleanup, ci, release process bazel Bazel related issues labels Dec 17, 2024
Mizux
Mizux approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchatelet gchatelet merged commit 4f45bf2 into main Dec 17, 2024
53 checks passed
@gchatelet gchatelet deleted the fix_windows_platform branch December 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mizux Mizux Mizux approved these changes

Assignees

@gchatelet gchatelet

Labels
bazel Bazel related issues misc non user facing: internal, cleanup, ci, release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gchatelet @Mizux