Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installed target definition. #39

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix installed target definition. #39

merged 1 commit into from
Nov 4, 2019

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 27, 2019

Using CMAKE_INSTALL_INCLUDEDIR before including GNUINstallDirs results
in a broken installation when CMAKE_INSTALL_PREFIX is a non-standard
directory.

Using CMAKE_INSTALL_INCLUDEDIR before including GNUINstallDirs results
in a broken installation when CMAKE_INSTALL_PREFIX is a non-standard
directory.
@pwnall pwnall merged commit b377ce4 into google:master Nov 4, 2019
@pwnall
Copy link
Member

pwnall commented Nov 4, 2019

Thank you for the fix, and sorry for the delay in reviewing!

Do you need this in a tagged release, or is master sufficient?

pwnall added a commit to pwnall/leveldb that referenced this pull request Nov 4, 2019
Using CMAKE_INSTALL_INCLUDEDIR before including GNUINstallDirs results
in a broken installation when CMAKE_INSTALL_PREFIX is a non-standard
directory.

Inspired from google/crc32c#39
@coryan coryan deleted the fix-include-path branch November 4, 2019 13:41
@coryan
Copy link
Contributor Author

coryan commented Nov 4, 2019

A tag eventually (say next few weeks) would be very useful. Thank you for asking.

pwnall added a commit to google/leveldb that referenced this pull request Nov 5, 2019
Using CMAKE_INSTALL_INCLUDEDIR before including GNUINstallDirs results
in a broken installation when CMAKE_INSTALL_PREFIX is a non-standard
directory.

Inspired from google/crc32c#39

PiperOrigin-RevId: 278427974
@pwnall
Copy link
Member

pwnall commented Nov 24, 2019

@coryan Tagged 1.1.1. Please let me know if this doesn't work for you.

@coryan
Copy link
Contributor Author

coryan commented Nov 25, 2019

This is great, thanks!

swiftomkar pushed a commit to swiftomkar/leveldb-triad that referenced this pull request Dec 6, 2020
Using CMAKE_INSTALL_INCLUDEDIR before including GNUINstallDirs results
in a broken installation when CMAKE_INSTALL_PREFIX is a non-standard
directory.

Inspired from google/crc32c#39

PiperOrigin-RevId: 278427974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants