Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #59

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix typo #59

merged 1 commit into from
Feb 8, 2022

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Feb 3, 2022

No description provided.

@rex4539
Copy link
Contributor Author

rex4539 commented Feb 7, 2022

@pwnall Could you please review?

pwnall
pwnall requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@pwnall pwnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting the typo!

CMakeLists.txt Outdated Show resolved Hide resolved
@rex4539 rex4539 requested a review from pwnall February 8, 2022 09:07
pwnall
pwnall approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@pwnall pwnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the revisions!

@pwnall pwnall merged commit 21fc8ef into google:main Feb 8, 2022
fanquake pushed a commit to fanquake/crc32c that referenced this pull request Apr 18, 2024
@rex4539 @fanquake
Fix typo (google#59)
1af1dbd
fanquake added a commit to bitcoin-core/crc32c-subtree that referenced this pull request Aug 30, 2024
@fanquake
Merge #8: Sync to upstream
efb8ea0 
21fc8ef Fix typo (google#59) (Dimitris Apostolou)
89f6984 Fix misspelled "Proccess" in comment (Munkybooty)
02e65f4 Bump deps (google#56) (Victor Costan)
b9d6e82 Fix Windows CI build. (google#54) (Victor Costan)
bbbb93a Switch CI to GitHub Actions (google#55) (Victor Costan)
d46cd17 Add clangd cache directory to .gitignore. (Victor Costan)

Pull request description:

  Pulls the few changes from upstream (last commit ~ 2 years ago).
  Seems reasonable to do before making any other changes. i.e #7, or if we are going to make further changes to the CMake build system etc.

Top commit has no ACKs.

Tree-SHA512: ca1cd5a085584d6a4ae65c5d83ae80db7bdd9ab251dc56fa899787dfa0b6fe0a60d32e89b5af5d066fa925a7120f02749aaa854e013f35c442f37a37a30caf23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwnall pwnall pwnall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rex4539 @pwnall