Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize fully qualified struct & enum name in schema binary #4025

Merged
1 commit merged into from
Sep 21, 2016

Conversation

paszea
Copy link

@paszea paszea commented Sep 15, 2016

replace #4024

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@paszea
Copy link
Author

paszea commented Sep 15, 2016

I signed it again

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@paszea
Copy link
Author

paszea commented Sep 15, 2016

i authored all the commits

@ghost
Copy link

ghost commented Sep 19, 2016

Looks good! But you still need to please googlebot somehow :)

@paszea
Copy link
Author

paszea commented Sep 19, 2016

I have no idea how to make it happy at this point. Do you know anyone from googlebot that can help?

@ghost
Copy link

ghost commented Sep 19, 2016

The commit says it was authored with Xun Liu, so (s)he needs to also sign/ok.

@paszea
Copy link
Author

paszea commented Sep 19, 2016

i am Xun Liu

@ghost
Copy link

ghost commented Sep 19, 2016

Look at the commit. It says Xun Liu committed with paszea. Apparently there is a xun@pinterest.com that GitHub doesn't know about. There's 2 different accounts associated with this commit.

@paszea
Copy link
Author

paszea commented Sep 20, 2016

add @xunl who is paszea

@xunl
Copy link
Contributor

xunl commented Sep 20, 2016

i am paszea and i approve the pr

@xunl
Copy link
Contributor

xunl commented Sep 20, 2016

now what?

@ghost
Copy link

ghost commented Sep 21, 2016

See the bots message. Did @xunl sign the license? and reply with "I signed it" or something?

@xunl
Copy link
Contributor

xunl commented Sep 21, 2016

i signed it

@xunl
Copy link
Contributor

xunl commented Sep 21, 2016

r+

@xunl
Copy link
Contributor

xunl commented Sep 21, 2016

i gave up

@ghost
Copy link

ghost commented Sep 21, 2016

Try I signed it! .. not sure how picky it is on spelling.

@paszea
Copy link
Author

paszea commented Sep 21, 2016

I signed it!

1 similar comment
@xunl
Copy link
Contributor

xunl commented Sep 21, 2016

I signed it!

@ghost
Copy link

ghost commented Sep 21, 2016

Ok, I am going to assume @googlebot is defective and merge it anyway. Commit authors both have consented and have a CLA.

@ghost ghost merged commit f6c1a1e into google:master Sep 21, 2016
@ghost
Copy link

ghost commented Sep 21, 2016

And thanks for the fix :)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants