-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialize fully qualified struct & enum name in schema binary #4025
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed it again |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
i authored all the commits |
Looks good! But you still need to please googlebot somehow :) |
I have no idea how to make it happy at this point. Do you know anyone from googlebot that can help? |
The commit says it was authored with Xun Liu, so (s)he needs to also sign/ok. |
i am Xun Liu |
Look at the commit. It says |
add @xunl who is paszea |
i am paszea and i approve the pr |
now what? |
See the bots message. Did @xunl sign the license? and reply with "I signed it" or something? |
i signed it |
r+ |
i gave up |
Try |
I signed it! |
1 similar comment
I signed it! |
Ok, I am going to assume @googlebot is defective and merge it anyway. Commit authors both have consented and have a CLA. |
And thanks for the fix :) |
replace #4024