Fixed javascript helper for typed arrays of scalars not taking into

[benssson]

account underlying buffer's byte offset.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[ghost]

Would it be better to stick the adding of the byteOffset to inside __vector, since every use of __vector would have this problem?

Do any other accessors have this problem? None of the offsets add byteOffset, so that may generally not be supported?

Also if you make changes to generated code, make sure to add the generated code to the commit (run sh generated_code.sh).

[benssson]

Signed!

Chu Joe Hoang

Sent from
https://polymail.io/

On Fri, 21 Oct 2016 at 10:14 googlebot

<
mailto:googlebot notifications@github.com

wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝

Please visit
https://cla.developers.google.com/
to sign.

Once you've signed, please reply here (e.g.

I signed it!

) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check
https://cla.developers.google.com/clas
and verify that your
https://help.github.com/articles/setting-your-email-in-git/
.

If you signed the CLA as a corporation, please let us know the company's name.

—

You are receiving this because you authored the thread.

Reply to this email directly,
#4068 (comment)
, or
https://github.com/notifications/unsubscribe-auth/AIaPeWU7ERK6h_D8jD09o3kTp6prtyMtks5q2IKGgaJpZM4KdBVZ
.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

[benssson]

Would it be better to stick the adding of the byteOffset to inside __vector, since every use of __vector would have this problem?

I don't think so (see below).

Do any other accessors have this problem? None of the offsets add byteOffset, so that may generally not be supported?

No, the other accessors don't use the TypedArray buffer property directly and instead use the [] operator (and so the byteOffset will already taken into account in those cases).
As far as I can tell, this is the only place where the buffer property is used to create a new view on the data and so should also take into consideration the byteOffset.

Also if you make changes to generated code, make sure to add the generated code to the commit (run sh generated_code.sh).

Thanks - done.

[googlebot]

CLAs look good, thanks!

[ghost]

Ah, that makes sense. Thanks!