[C++] Support C++ object copies #5988

jfroy · 2020-06-19T20:30:06Z

Augment the C++ generator to emit C++ copy/move constructors and assignment operators. This is enabled by default when the C++ standard is C++11 or later. These additional functions are only emitted for objects that need it.

The copy ctor and assignment operator are declared in the object table type and are defined as inline functions after table declarations.

When copy/move ctors and assignment operators are declared, a user-defined explicitly-defaulted default ctor is also emitted.

--- a/tests/cpp17/generated_cpp17/monster_test_generated.h
+++ b/tests/cpp17/generated_cpp17/monster_test_generated.h
@@ -1012,6 +1012,11 @@ struct MonsterT : public flatbuffers::NativeTable {
   MyGame::Example::AnyAmbiguousAliasesUnion any_ambiguous{};
   std::vector<MyGame::Example::Color> vector_of_enums{};
   MyGame::Example::Race signed_enum = MyGame::Example::Race::None;
+  MonsterT() = default;
+  MonsterT(const MonsterT &o);
+  MonsterT(MonsterT&&) FLATBUFFERS_NOEXCEPT = default;
+  MonsterT &operator=(const MonsterT &o);
+  MonsterT &operator=(MonsterT&&) FLATBUFFERS_NOEXCEPT = default;
 };
 
 /// an example documentation comment: "monster object"
@@ -2285,6 +2290,176 @@ inline flatbuffers::Offset<Referrable> CreateReferrable(flatbuffers::FlatBufferB
       _id);
 }
 
+inline MonsterT::MonsterT(const MonsterT &o)
+      : pos((o.pos) ? new MyGame::Example::Vec3(*o.pos) : nullptr),
+        mana(o.mana),
+        hp(o.hp),
+        name(o.name),
+        color(o.color),
+        test(o.test),
+        enemy((o.enemy) ? new MyGame::Example::MonsterT(*o.enemy) : nullptr),
+        testempty((o.testempty) ? new MyGame::Example::StatT(*o.testempty) : nullptr),
+        testbool(o.testbool),
+        testhashs32_fnv1(o.testhashs32_fnv1),
+        testhashu32_fnv1(o.testhashu32_fnv1),
+        testhashs64_fnv1(o.testhashs64_fnv1),
+        testhashu64_fnv1(o.testhashu64_fnv1),
+        testhashs32_fnv1a(o.testhashs32_fnv1a),
+        testhashu32_fnv1a(o.testhashu32_fnv1a),
+        testhashs64_fnv1a(o.testhashs64_fnv1a),
+        testhashu64_fnv1a(o.testhashu64_fnv1a),
+        testf(o.testf),
+        testf2(o.testf2),
+        testf3(o.testf3),
+        parent_namespace_test((o.parent_namespace_test) ? new MyGame::InParentNamespaceT(*o.parent_namespace_test) : nullptr),
+        single_weak_reference(o.single_weak_reference),
+        co_owning_reference(o.co_owning_reference),
+        non_owning_reference(o.non_owning_reference),
+        any_unique(o.any_unique),
+        any_ambiguous(o.any_ambiguous),
+        signed_enum(o.signed_enum) {
+  inventory.clear();
+  inventory.reserve(o.inventory.size());
+  for (const auto &v : o.inventory) { inventory.emplace_back(v); }
+  test4.clear();
+  test4.reserve(o.test4.size());
+  for (const auto &v : o.test4) { test4.emplace_back(v); }
+  testarrayofstring.clear();
+  testarrayofstring.reserve(o.testarrayofstring.size());
+  for (const auto &v : o.testarrayofstring) { testarrayofstring.emplace_back(v); }
+  testarrayoftables.clear();
+  testarrayoftables.reserve(o.testarrayoftables.size());
+  for (const auto &v : o.testarrayoftables) { testarrayoftables.emplace_back((v) ? new MyGame::Example::MonsterT(*v) : nullptr); }
+  testnestedflatbuffer.clear();
+  testnestedflatbuffer.reserve(o.testnestedflatbuffer.size());
+  for (const auto &v : o.testnestedflatbuffer) { testnestedflatbuffer.emplace_back(v); }
+  testarrayofbools.clear();
+  testarrayofbools.reserve(o.testarrayofbools.size());
+  for (const auto &v : o.testarrayofbools) { testarrayofbools.emplace_back(v); }
+  testarrayofstring2.clear();
+  testarrayofstring2.reserve(o.testarrayofstring2.size());
+  for (const auto &v : o.testarrayofstring2) { testarrayofstring2.emplace_back(v); }
+  testarrayofsortedstruct.clear();
+  testarrayofsortedstruct.reserve(o.testarrayofsortedstruct.size());
+  for (const auto &v : o.testarrayofsortedstruct) { testarrayofsortedstruct.emplace_back(v); }
+  flex.clear();
+  flex.reserve(o.flex.size());
+  for (const auto &v : o.flex) { flex.emplace_back(v); }
+  test5.clear();
+  test5.reserve(o.test5.size());
+  for (const auto &v : o.test5) { test5.emplace_back(v); }
+  vector_of_longs.clear();
+  vector_of_longs.reserve(o.vector_of_longs.size());
+  for (const auto &v : o.vector_of_longs) { vector_of_longs.emplace_back(v); }
+  vector_of_doubles.clear();
+  vector_of_doubles.reserve(o.vector_of_doubles.size());
+  for (const auto &v : o.vector_of_doubles) { vector_of_doubles.emplace_back(v); }
+  vector_of_referrables.clear();
+  vector_of_referrables.reserve(o.vector_of_referrables.size());
+  for (const auto &v : o.vector_of_referrables) { vector_of_referrables.emplace_back((v) ? new MyGame::Example::ReferrableT(*v) : nullptr); }
+  vector_of_weak_references.clear();
+  vector_of_weak_references.reserve(o.vector_of_weak_references.size());
+  for (const auto &v : o.vector_of_weak_references) { vector_of_weak_references.emplace_back(v); }
+  vector_of_strong_referrables.clear();
+  vector_of_strong_referrables.reserve(o.vector_of_strong_referrables.size());
+  for (const auto &v : o.vector_of_strong_referrables) { vector_of_strong_referrables.emplace_back((v) ? new MyGame::Example::ReferrableT(*v) : nullptr); }
+  vector_of_co_owning_references.clear();
+  vector_of_co_owning_references.reserve(o.vector_of_co_owning_references.size());
+  for (const auto &v : o.vector_of_co_owning_references) { vector_of_co_owning_references.emplace_back((v) ? new ReferrableT(*v) : nullptr); }
+  vector_of_non_owning_references.clear();
+  vector_of_non_owning_references.reserve(o.vector_of_non_owning_references.size());
+  for (const auto &v : o.vector_of_non_owning_references) { vector_of_non_owning_references.emplace_back(v); }
+  vector_of_enums.clear();
+  vector_of_enums.reserve(o.vector_of_enums.size());
+  for (const auto &v : o.vector_of_enums) { vector_of_enums.emplace_back(v); }
+}
+
+inline MonsterT &MonsterT::operator=(const MonsterT &o) {
+  pos.reset((o.pos) ? new MyGame::Example::Vec3(*o.pos) : nullptr);
+  mana = o.mana;
+  hp = o.hp;
+  name = o.name;
+  color = o.color;
+  test = o.test;
+  enemy.reset((o.enemy) ? new MyGame::Example::MonsterT(*o.enemy) : nullptr);
+  testempty.reset((o.testempty) ? new MyGame::Example::StatT(*o.testempty) : nullptr);
+  testbool = o.testbool;
+  testhashs32_fnv1 = o.testhashs32_fnv1;
+  testhashu32_fnv1 = o.testhashu32_fnv1;
+  testhashs64_fnv1 = o.testhashs64_fnv1;
+  testhashu64_fnv1 = o.testhashu64_fnv1;
+  testhashs32_fnv1a = o.testhashs32_fnv1a;
+  testhashu32_fnv1a = o.testhashu32_fnv1a;
+  testhashs64_fnv1a = o.testhashs64_fnv1a;
+  testhashu64_fnv1a = o.testhashu64_fnv1a;
+  testf = o.testf;
+  testf2 = o.testf2;
+  testf3 = o.testf3;
+  parent_namespace_test.reset((o.parent_namespace_test) ? new MyGame::InParentNamespaceT(*o.parent_namespace_test) : nullptr);
+  single_weak_reference = o.single_weak_reference;
+  co_owning_reference = o.co_owning_reference;
+  non_owning_reference = o.non_owning_reference;
+  any_unique = o.any_unique;
+  any_ambiguous = o.any_ambiguous;
+  signed_enum = o.signed_enum;
+  inventory.clear();
+  inventory.reserve(o.inventory.size());
+  for (const auto &v : o.inventory) { inventory.emplace_back(v); }
+  test4.clear();
+  test4.reserve(o.test4.size());
+  for (const auto &v : o.test4) { test4.emplace_back(v); }
+  testarrayofstring.clear();
+  testarrayofstring.reserve(o.testarrayofstring.size());
+  for (const auto &v : o.testarrayofstring) { testarrayofstring.emplace_back(v); }
+  testarrayoftables.clear();
+  testarrayoftables.reserve(o.testarrayoftables.size());
+  for (const auto &v : o.testarrayoftables) { testarrayoftables.emplace_back((v) ? new MyGame::Example::MonsterT(*v) : nullptr); }
+  testnestedflatbuffer.clear();
+  testnestedflatbuffer.reserve(o.testnestedflatbuffer.size());
+  for (const auto &v : o.testnestedflatbuffer) { testnestedflatbuffer.emplace_back(v); }
+  testarrayofbools.clear();
+  testarrayofbools.reserve(o.testarrayofbools.size());
+  for (const auto &v : o.testarrayofbools) { testarrayofbools.emplace_back(v); }
+  testarrayofstring2.clear();
+  testarrayofstring2.reserve(o.testarrayofstring2.size());
+  for (const auto &v : o.testarrayofstring2) { testarrayofstring2.emplace_back(v); }
+  testarrayofsortedstruct.clear();
+  testarrayofsortedstruct.reserve(o.testarrayofsortedstruct.size());
+  for (const auto &v : o.testarrayofsortedstruct) { testarrayofsortedstruct.emplace_back(v); }
+  flex.clear();
+  flex.reserve(o.flex.size());
+  for (const auto &v : o.flex) { flex.emplace_back(v); }
+  test5.clear();
+  test5.reserve(o.test5.size());
+  for (const auto &v : o.test5) { test5.emplace_back(v); }
+  vector_of_longs.clear();
+  vector_of_longs.reserve(o.vector_of_longs.size());
+  for (const auto &v : o.vector_of_longs) { vector_of_longs.emplace_back(v); }
+  vector_of_doubles.clear();
+  vector_of_doubles.reserve(o.vector_of_doubles.size());
+  for (const auto &v : o.vector_of_doubles) { vector_of_doubles.emplace_back(v); }
+  vector_of_referrables.clear();
+  vector_of_referrables.reserve(o.vector_of_referrables.size());
+  for (const auto &v : o.vector_of_referrables) { vector_of_referrables.emplace_back((v) ? new MyGame::Example::ReferrableT(*v) : nullptr); }
+  vector_of_weak_references.clear();
+  vector_of_weak_references.reserve(o.vector_of_weak_references.size());
+  for (const auto &v : o.vector_of_weak_references) { vector_of_weak_references.emplace_back(v); }
+  vector_of_strong_referrables.clear();
+  vector_of_strong_referrables.reserve(o.vector_of_strong_referrables.size());
+  for (const auto &v : o.vector_of_strong_referrables) { vector_of_strong_referrables.emplace_back((v) ? new MyGame::Example::ReferrableT(*v) : nullptr); }
+  vector_of_co_owning_references.clear();
+  vector_of_co_owning_references.reserve(o.vector_of_co_owning_references.size());
+  for (const auto &v : o.vector_of_co_owning_references) { vector_of_co_owning_references.emplace_back((v) ? new ReferrableT(*v) : nullptr); }
+  vector_of_non_owning_references.clear();
+  vector_of_non_owning_references.reserve(o.vector_of_non_owning_references.size());
+  for (const auto &v : o.vector_of_non_owning_references) { vector_of_non_owning_references.emplace_back(v); }
+  vector_of_enums.clear();
+  vector_of_enums.reserve(o.vector_of_enums.size());
+  for (const auto &v : o.vector_of_enums) { vector_of_enums.emplace_back(v); }
+
+  return *this;
+}
+
 inline MonsterT *Monster::UnPack(const flatbuffers::resolver_function_t *_resolver) const {
   auto _o = std::make_unique<MonsterT>();
   UnPackTo(_o.get(), _resolver);
@@ -2590,7 +2765,7 @@ inline flatbuffers::Offset<void> AnyUnion::Pack(flatbuffers::FlatBufferBuilder &
 inline AnyUnion::AnyUnion(const AnyUnion &u) : type(u.type), value(nullptr) {
   switch (type) {
     case Any::Monster: {
-      FLATBUFFERS_ASSERT(false);  // MyGame::Example::MonsterT not copyable.
+      value = new MyGame::Example::MonsterT(*reinterpret_cast<MyGame::Example::MonsterT *>(u.value));
       break;
     }
     case Any::TestSimpleTableWithEnum: {
@@ -2701,7 +2876,7 @@ inline flatbuffers::Offset<void> AnyUniqueAliasesUnion::Pack(flatbuffers::FlatBu
 inline AnyUniqueAliasesUnion::AnyUniqueAliasesUnion(const AnyUniqueAliasesUnion &u) : type(u.type), value(nullptr) {
   switch (type) {
     case AnyUniqueAliases::M: {
-      FLATBUFFERS_ASSERT(false);  // MyGame::Example::MonsterT not copyable.
+      value = new MyGame::Example::MonsterT(*reinterpret_cast<MyGame::Example::MonsterT *>(u.value));
       break;
     }
     case AnyUniqueAliases::TS: {
@@ -2812,15 +2987,15 @@ inline flatbuffers::Offset<void> AnyAmbiguousAliasesUnion::Pack(flatbuffers::Fla
 inline AnyAmbiguousAliasesUnion::AnyAmbiguousAliasesUnion(const AnyAmbiguousAliasesUnion &u) : type(u.type), value(nullptr) {
   switch (type) {
     case AnyAmbiguousAliases::M1: {
-      FLATBUFFERS_ASSERT(false);  // MyGame::Example::MonsterT not copyable.
+      value = new MyGame::Example::MonsterT(*reinterpret_cast<MyGame::Example::MonsterT *>(u.value));
       break;
     }
     case AnyAmbiguousAliases::M2: {
-      FLATBUFFERS_ASSERT(false);  // MyGame::Example::MonsterT not copyable.
+      value = new MyGame::Example::MonsterT(*reinterpret_cast<MyGame::Example::MonsterT *>(u.value));
       break;
     }
     case AnyAmbiguousAliases::M3: {
-      FLATBUFFERS_ASSERT(false);  // MyGame::Example::MonsterT not copyable.
+      value = new MyGame::Example::MonsterT(*reinterpret_cast<MyGame::Example::MonsterT *>(u.value));
       break;
     }

aardappel

Thanks, cool feature! Did you run sh generate_code.sh ? I think there's some generated code files missing. Mention this in the C++ docs? We should have a section that documents what changes with the different C++ standard settings.
@vglavnyy

src/idl_gen_cpp.cpp

tests/cpp17/generated_cpp17/monster_test_generated.h

jfroy · 2020-06-22T23:27:42Z

Thanks, cool feature! Did you run sh generate_code.sh ? I think there's some generated code files missing. Mention this in the C++ docs? We should have a section that documents what changes with the different C++ standard settings.
@vglavnyy

I did run generate_code.sh and the only modified file is tests/cpp17/generated_cpp17/monster_test_generated.h. By default, flatc runs in C++0X mode and thus most of the existing tests and generated files are not impacted by this patch.

vglavnyy

It looks good.
I need a few days to clone and test this PR locally.

src/idl_gen_cpp.cpp

jfroy · 2020-06-23T16:12:17Z

Rebased and added code to emit a explicitly-defaulted default constructor for types that will have a copy/move ctor/assignment operator.

vglavnyy · 2020-06-28T05:38:01Z

I've examined PR code.
Copying of unique_ptr looks a little bit confusing but I think it is normal for the Obj-API objects.

I think it would be better to use copy-swap for generated assignment operators. This pattern has strong guarantees against exceptions (commit-or-rollback).

Probably clear() call isn't necessary for copy constructors:

  testarrayofbools.clear(); // testarrayofbools is empty, it just constructed
  testarrayofbools.reserve(o.testarrayofbools.size());
  for (const auto &v : o.testarrayofbools) { testarrayofbools.emplace_back(v); }

Maybe add a template routine for the reserve-for-clone pattern into utils.h or flatbuffers.h?

template<class V>
void append_clone_of_vector(const V& from, V& to) {
 reserve()
 for(v : from) { to.emplace_back(...) }
}

jfroy · 2020-07-01T18:56:28Z

Thanks for the feedback @vglavnyy . I'll get working on that next week after the break in the US.

github-actions · 2020-12-30T20:49:35Z

This pull request is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days.

catid · 2021-01-08T03:36:46Z

This would be appreciated

Merging google#5988

aardappel · 2021-05-03T18:38:55Z

@jfroy do you have time to finish this?

jfroy · 2021-05-05T17:03:51Z

@jfroy do you have time to finish this?

Not immediately. I had to put this on hold, but I'll in fact have some free time in May. Maybe I can finish this up.

OlivierLDff · 2021-08-08T07:58:43Z

Any news about this PR?
Would be very interested to reduce verbosity of my current copies of ObjectT

google-cla · 2021-08-11T15:18:01Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

jfroy · 2021-08-11T17:25:51Z

I've examined PR code.
Copying of unique_ptr looks a little bit confusing but I think it is normal for the Obj-API objects.

I think it would be better to use copy-swap for generated assignment operators. This pattern has strong guarantees against exceptions (commit-or-rollback).

Probably clear() call isn't necessary for copy constructors:
  testarrayofbools.clear(); // testarrayofbools is empty, it just constructed
  testarrayofbools.reserve(o.testarrayofbools.size());
  for (const auto &v : o.testarrayofbools) { testarrayofbools.emplace_back(v); }
Maybe add a template routine for the reserve-for-clone pattern into utils.h or flatbuffers.h?
template<class V>
void append_clone_of_vector(const V& from, V& to) {
 reserve()
 for(v : from) { to.emplace_back(...) }
}

I've updated the PR to use copy-and-swap. I did not switch to a helper function for vector cloning because it didn't seem worth it and raised some annoying namespace issues.

jfroy · 2021-08-11T18:48:11Z

Improved the generator a bit to use std::vector's copy constructor for non-pointer element types. This allows more efficient copies for trivially-copyable element types (where an implementation may do a memcpy). This also deals with std::vector<bool> (🙄).

Not sure why CI / Build Kotlin is unhappy.

jfroy · 2021-08-11T18:52:36Z

Any news about this PR?
Would be very interested to reduce verbosity of my current copies of ObjectT

Thanks for, huh, encouraging me to try to finish this.

OlivierLDff · 2021-08-11T19:09:56Z

Not sure why CI / Build Kotlin is unhappy.

Seems that it is the same in master

Thanks for the work!

aardappel · 2021-08-12T20:56:24Z

@vglavnyy this look good to you now?

@krojew @paulovap seems Kotlin is still broken due to the Java 8 related changes, what do we do about this?

krojew · 2021-08-13T06:44:48Z

@aardappel I don't know Kotlin, so I can't help much there.

Also, what is the semantics of copying tables? Does it simply copy references? If so, it can lead to a strange situation with mutating API, when mutating a single copy, mutates every copy.

jfroy · 2021-08-13T06:47:53Z

Also, what is the semantics of copying tables? Does it simply copy references? If so, it can lead to a strange situation with mutating API, when mutating a single copy, mutates every copy.

Table objects are deep-copied recursively. In other words, they act as value types. Any other semantic, as you point out, is broken.

aardappel · 2021-08-13T20:58:27Z

@krojew isn't Kotlin failing on your Java changes though? Or am I not understanding correctly?

They both run on the same JVM and are subject to the same object/casting rules, so I wouldn't think it's so different :)

krojew · 2021-08-13T21:01:31Z

@aardappel technically yes, but I have no idea why. It's complaining about missing symbols which do exist when using Java, so it's something kotlin specific.

paulovap · 2021-08-13T21:05:44Z

@krojew isn't Kotlin failing on your Java changes though? Or am I not understanding correctly?

They both run on the same JVM and are subject to the same object/casting rules, so I wouldn't think it's so different :)

I will have some time to check whats going on with Kotlin tomorrow.

Edit: I took a look and the issue is that with @krojew changes its no longer possible to use Java 8 compiler to build the java source code. I just updated CI to use Java 11, while it still emits Java 8 bytecode.

I believe #6764 should be enough to fix the original issue that @krojew tried to fix, so his changes are no longer necessary, but this is something we can revert afterwards

Fix is in #6783

bjornharrtell · 2021-08-14T19:56:46Z

@paulovap I think you are right and I've created a PR with the revert of those changes here #6785.

dbaileychess · 2021-09-22T16:11:51Z

Like to ping this again to see if we can get it in.

jfroy · 2021-09-22T16:14:31Z

I thought it was ready to go and waiting for review, but it seems some old Visual Studio versions have problems in CI. I'll try to spend time soon to address those.

dbaileychess · 2021-12-13T21:52:22Z

@jfory CI might be better now that we have drop support for VS2010. Mind updating?

jfroy · 2021-12-13T22:30:23Z

@jfory CI might be better now that we have drop support for VS2010. Mind updating?

Thanks for the ping. I rebased and looks like CI is now green. I was hoping to get the time to rework the patch to deal with (very) old compiler toolchains, but looks like I won't have to.

dbaileychess · 2021-12-13T23:47:30Z

Ok, thanks! I'll take one more review tonight and try to get it in.

dbaileychess · 2021-12-14T04:42:25Z

It looks good to me, though we should add some tests.

jfroy · 2021-12-16T18:56:42Z

It looks good to me, though we should add some tests.

I've added a basic copy test by extending ObjectFlatBuffersTest.

Augment the C++ generator to emit a C++ copy constructor and a by-value copy assignment operator. This is enabled by default when the C++ standard is C++11 or later. These additional functions are only emitted for objects that need it, typically tables containing other tables. These new functions are declared in the object table type and are defined as inline functions after table declarations. When these new functions are declared, a user-defined explicitly-defaulted default constructor and move constructor are also emitted. The copy assignment operator uses the copy-and-swap idiom to provide strong exception safety, at the expense of keeping 2 full table copies in memory temporarily. fixes #5783

dbaileychess · 2022-01-29T03:52:43Z

Sorry for the delay, looks good and thanks for adding the test.

Anything pending or can I submit?

jfroy · 2022-01-29T06:27:25Z

Sorry for the delay, looks good and thanks for adding the test.

Anything pending or can I submit?

Nope good to go.

dbaileychess · 2022-01-29T22:24:29Z

Thank you!

jfroy changed the title ~~[C++] Support C++ object copies (#5783)~~ [C++] Support C++ object copies Jun 19, 2020

jfroy changed the title ~~[C++] Support C++ object copies~~ [C++] Support C++ object copies (fixes #5783) Jun 19, 2020

jfroy changed the title ~~[C++] Support C++ object copies (fixes #5783)~~ [C++] Support C++ object copies Jun 19, 2020

jfroy mentioned this pull request Jun 19, 2020

[C++] Generate default member initializers for >= C++11 #5989

Merged

aardappel reviewed Jun 22, 2020

View reviewed changes

src/idl_gen_cpp.cpp Outdated Show resolved Hide resolved

src/idl_gen_cpp.cpp Outdated Show resolved Hide resolved

tests/cpp17/generated_cpp17/monster_test_generated.h Outdated Show resolved Hide resolved

tests/cpp17/generated_cpp17/monster_test_generated.h Outdated Show resolved Hide resolved

vglavnyy reviewed Jun 23, 2020

View reviewed changes

src/idl_gen_cpp.cpp Outdated Show resolved Hide resolved

src/idl_gen_cpp.cpp Outdated Show resolved Hide resolved

cdfh mentioned this pull request Aug 31, 2020

Copy constructor for C++ Object API #5783

Closed

github-actions bot added the stale label Dec 30, 2020

catid added a commit to catid/flatbuffers that referenced this pull request Jan 8, 2021

Merging google#5988

f669f5d

catid added a commit to catid/flatbuffers that referenced this pull request Jan 8, 2021

Merge pull request #1 from catid/catid/copyctor

7a523c9

Merging google#5988

github-actions bot closed this Jan 22, 2021

dbaileychess reopened this Jan 22, 2021

dbaileychess removed the stale label Jan 22, 2021

piotrdz mentioned this pull request May 1, 2021

[C++] Native union of struct/table with nested struct is not copyable #6552

Closed

github-actions bot added c++ codegen Involving generating code from schema labels Aug 11, 2021

dbaileychess merged commit 4320398 into google:master Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C++] Support C++ object copies #5988

[C++] Support C++ object copies #5988

jfroy commented Jun 19, 2020 •

edited

Loading

aardappel left a comment

jfroy commented Jun 22, 2020

vglavnyy left a comment

jfroy commented Jun 23, 2020

vglavnyy commented Jun 28, 2020

jfroy commented Jul 1, 2020

github-actions bot commented Dec 30, 2020

catid commented Jan 8, 2021

aardappel commented May 3, 2021

jfroy commented May 5, 2021

OlivierLDff commented Aug 8, 2021

google-cla bot commented Aug 11, 2021

jfroy commented Aug 11, 2021

jfroy commented Aug 11, 2021

jfroy commented Aug 11, 2021

OlivierLDff commented Aug 11, 2021

aardappel commented Aug 12, 2021

krojew commented Aug 13, 2021

jfroy commented Aug 13, 2021 •

edited

Loading

aardappel commented Aug 13, 2021

krojew commented Aug 13, 2021

paulovap commented Aug 13, 2021 •

edited

Loading

bjornharrtell commented Aug 14, 2021

dbaileychess commented Sep 22, 2021

jfroy commented Sep 22, 2021

dbaileychess commented Dec 13, 2021

jfroy commented Dec 13, 2021

dbaileychess commented Dec 13, 2021

dbaileychess commented Dec 14, 2021

jfroy commented Dec 16, 2021

dbaileychess commented Jan 29, 2022

jfroy commented Jan 29, 2022

dbaileychess commented Jan 29, 2022

[C++] Support C++ object copies #5988

[C++] Support C++ object copies #5988

Conversation

jfroy commented Jun 19, 2020 • edited Loading

aardappel left a comment

Choose a reason for hiding this comment

jfroy commented Jun 22, 2020

vglavnyy left a comment

Choose a reason for hiding this comment

jfroy commented Jun 23, 2020

vglavnyy commented Jun 28, 2020

jfroy commented Jul 1, 2020

github-actions bot commented Dec 30, 2020

catid commented Jan 8, 2021

aardappel commented May 3, 2021

jfroy commented May 5, 2021

OlivierLDff commented Aug 8, 2021

google-cla bot commented Aug 11, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

jfroy commented Aug 11, 2021

jfroy commented Aug 11, 2021

jfroy commented Aug 11, 2021

OlivierLDff commented Aug 11, 2021

aardappel commented Aug 12, 2021

krojew commented Aug 13, 2021

jfroy commented Aug 13, 2021 • edited Loading

aardappel commented Aug 13, 2021

krojew commented Aug 13, 2021

paulovap commented Aug 13, 2021 • edited Loading

bjornharrtell commented Aug 14, 2021

dbaileychess commented Sep 22, 2021

jfroy commented Sep 22, 2021

dbaileychess commented Dec 13, 2021

jfroy commented Dec 13, 2021

dbaileychess commented Dec 13, 2021

dbaileychess commented Dec 14, 2021

jfroy commented Dec 16, 2021

dbaileychess commented Jan 29, 2022

jfroy commented Jan 29, 2022

dbaileychess commented Jan 29, 2022

jfroy commented Jun 19, 2020 •

edited

Loading

jfroy commented Aug 13, 2021 •

edited

Loading

paulovap commented Aug 13, 2021 •

edited

Loading