Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Fix union copy constructor to work with nested structs (#6552) #6607

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

piotrdz
Copy link
Contributor

@piotrdz piotrdz commented May 1, 2021

This will assert that any struct type is copyable and the corresponding copy constructor call will be generated.

For table types, the logic remains unchanged.

@google-cla
Copy link

google-cla bot commented May 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels May 1, 2021
@piotrdz
Copy link
Contributor Author

piotrdz commented May 2, 2021

@googlebot I signed it!

@aardappel
Copy link
Collaborator

Well, that is simple.. I guess there were no existing tests affected by this? did you run generate_code.sh ?

@piotrdz
Copy link
Contributor Author

piotrdz commented May 4, 2021

I ran generate_code.sh, but there were no changes to the generated files. This pattern (union of structs) is not used in tests.

@aardappel
Copy link
Collaborator

Ok, fair enough, we'll merge this for now.

@aardappel aardappel merged commit 47361ba into google:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants