Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python tests #7960

Merged
merged 9 commits into from
May 17, 2023
Merged

Fix python tests #7960

merged 9 commits into from
May 17, 2023

Conversation

yan12125
Copy link
Contributor

WIP - create a PR to see if tests are correctly run


Thank you for submitting a PR!

Please delete this standard text once you've created your own description.

If you make changes to any of the code generators (src/idl_gen*) be sure to
build your project, as it will generate code based on the changes. If necessary
the code generation script can be directly run (scripts/generate_code.py),
requires Python3. This allows us to better see the effect of the PR.

If your PR includes C++ code, please adhere to the
Google C++ Style Guide,
and don't forget we try to support older compilers (e.g. VS2010, GCC 4.6.3),
so only some C++11 support is available.

For any C++ changes, please make sure to run sh scripts/clang-format-git.sh

Include other details as appropriate.

Thanks!

@github-actions github-actions bot added c++ codegen Involving generating code from schema python labels May 13, 2023
@yan12125 yan12125 mentioned this pull request May 13, 2023
@dbaileychess
Copy link
Collaborator

Could you also update the CI builds?

@github-actions github-actions bot added the CI Continuous Integration label May 15, 2023
@musicinmybrain
Copy link
Contributor

I have not reviewed the contents of this PR or checked whether it fully solves the referenced bugs.

I have verified that, after rebasing this PR to the 23.5.9 release and applying it as a patch to the Fedora Linux flatbuffers package, the Python tests again pass on all relevant architectures: x86_64, aarch64, ppc64le, s390x.

Still, I’m holding off on updating the package in Fedora Rawhide from 23.3.3 until things settle out a bit—probably waiting for the next release. (Since flatbuffers offers no ABI stability guarantees., it’s never updated in stable Fedora branches anyway.)

@dbaileychess
Copy link
Collaborator

@maxburke Can you comment, as you introduce these changes.

@maxburke
Copy link
Contributor

@maxburke Can you comment, as you introduce these changes.

I remember that we used dot-prefixed imports to sort out some issues where Python couldn't resolve some paths. I can't remember the exact reason why. If there are tests that pass when this is merged that don't otherwise then let's merge this change and I can sort out any of the failures I'm encountering at a later date.

@yan12125 yan12125 marked this pull request as ready for review May 16, 2023 12:03
@github-actions github-actions bot added the grpc label May 16, 2023
@yan12125
Copy link
Contributor Author

Thanks, I pushed another commit to fix CI. This should be ready for reviews now.

@dbaileychess dbaileychess enabled auto-merge (squash) May 16, 2023 23:07
@yan12125
Copy link
Contributor Author

The test failure seems unrelated:

external/boringssl/src/crypto/x509/t_x509.c:321:18: error: variable 'l' set but not used [-Werror,-Wunused-but-set-variable]

(https://buildkite.com/bazel/flatbuffers/builds/8508#018826d1-4342-4d50-a470-4095f006948c)

@dbaileychess dbaileychess merged commit a352bdb into google:master May 17, 2023
@dbaileychess
Copy link
Collaborator

Thanks!

@yan12125 yan12125 deleted the fix-python-tests branch May 18, 2023 00:21
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Don't generate types unless --python-typing specified

Fixes google#7944

* Fix incorrect import statements

Fixes google#7951

* Fix $PYTHONPATH in PythonTest.sh

Regressed from google#7529

* PythonTest: fail if something goes wrong

GitHub Actions runs `bash PythonTest.sh`, and thus failures were not
visible.

* Build flatc for Python tests

* Regenerate codes

---------

Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Don't generate types unless --python-typing specified

Fixes google#7944

* Fix incorrect import statements

Fixes google#7951

* Fix $PYTHONPATH in PythonTest.sh

Regressed from google#7529

* PythonTest: fail if something goes wrong

GitHub Actions runs `bash PythonTest.sh`, and thus failures were not
visible.

* Build flatc for Python tests

* Regenerate codes

---------

Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ CI Continuous Integration codegen Involving generating code from schema grpc python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants