Fixes the wrong positioning #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the condition flexWrap = No wrap and justifyContent = center. This happened because when flexWrap = no wrap, the anchor position retrieved from the existing view was wrong. Because the OrientationHelper is changed to perpendicularly when flexWrap is nowrap.
MGaetan89
reviewed
Nov 15, 2018
flexbox/src/main/java/com/google/android/flexbox/FlexboxLayoutManager.java
Outdated
Show resolved
Hide resolved
Added the test when flex direction is column.
Closed
1 task
|
@thagikura @MGaetan89 Is this fix available in v1.1.0 or do we have next version? |
|
Version 1.1.0 was released Sept. 25th, and this was merged Nov. 16th. |
|
Thanks @MGaetan89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the condition flexWrap = No wrap and justifyContent = center.
This happened because when flexWrap = no wrap, the anchor position
retrieved from the existing view was wrong. Because the OrientationHelper
is changed to perpendicularly when flexWrap is nowrap.