Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small windows compiling error #127

Closed
Max9403 opened this issue Oct 21, 2020 · 1 comment
Closed

Small windows compiling error #127

Max9403 opened this issue Oct 21, 2020 · 1 comment

Comments

@Max9403
Copy link

Max9403 commented Oct 21, 2020 •
edited
Loading

This seems too simple to be worth a pull request but line 50 in fruit/impl/data_structures/semistatic_map.h

std::numeric_limits<NumBits>::max()
needs to be changed to
(std::numeric_limits<NumBits>::max)()

To fix a mix up with the max macro from a Window's header (extra info: https://stackoverflow.com/questions/27442885/syntax-error-with-stdnumeric-limitsmax)
poletti-marco added a commit that referenced this issue Oct 24, 2020
@poletti-marco
Add a pair of parentheses so that a use of a "max" function in Fruit …
125c403 
…don't get expanded by a macro on Windows.

See #127.
@poletti-marco
Copy link
Contributor

Hi, thanks for reporting!
I fixed this in 125c403.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Max9403 @poletti-marco