Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sergiu Deitsch <sergiud@users.noreply.github.com>
  • Loading branch information
lstaroth and sergiud authored Aug 6, 2022
1 parent 370ac0f commit 82b2518
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/glog/logging.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -1321,17 +1321,17 @@ const LogSeverity GLOG_0 = GLOG_ERROR;

#else // !DCHECK_IS_ON()

#define DLOG(severity) if(false) LOG(severity)
#define DLOG(severity) if((false)) LOG(severity)

#define DVLOG(verboselevel) if(false && VLOG_IS_ON(verboselevel)) LOG(INFO)
#define DVLOG(verboselevel) if((false) && VLOG_IS_ON(verboselevel)) LOG(INFO)

#define DLOG_IF(severity, condition) if(false && (condition)) LOG(severity)
#define DLOG_IF(severity, condition) if((false) && (condition)) LOG(severity)

#define DLOG_EVERY_N(severity, n) if(false) LOG(severity)
#define DLOG_EVERY_N(severity, n) if((false)) LOG(severity)

#define DLOG_IF_EVERY_N(severity, condition, n) if(false && (condition)) LOG(severity)
#define DLOG_IF_EVERY_N(severity, condition, n) if((false) && (condition)) LOG(severity)

#define DLOG_ASSERT(condition) if(false) LOG_ASSERT(condition)
#define DLOG_ASSERT(condition) if((false)) LOG_ASSERT(condition)

// MSVC warning C4127: conditional expression is constant
#define DCHECK(condition) \
Expand Down

0 comments on commit 82b2518

Please sign in to comment.