Skip to content

Commit

Permalink
fix(symbolize): format unknown stack frames (#1092)
Browse files Browse the repository at this point in the history
  • Loading branch information
xppt committed Apr 22, 2024
1 parent c0813f9 commit cd4ef77
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions src/symbolize.cc
Original file line number Diff line number Diff line change
Expand Up @@ -642,18 +642,13 @@ OpenObjectFileContainingPcAndGetStartAddress(uint64_t pc,
return nullptr; // Malformed line.
}

strncpy(out_file_name, cursor, out_file_name_size);
// Making sure |out_file_name| is always null-terminated.
out_file_name[out_file_name_size - 1] = '\0';

// Finally, "cursor" now points to file name of our interest.
FileDescriptor object_fd{
return FileDescriptor{
FailureRetry([cursor] { return open(cursor, O_RDONLY); })};
if (!object_fd) {
// Failed to open object file. Copy the object file name to
// |out_file_name|.
strncpy(out_file_name, cursor, out_file_name_size);
// Making sure |out_file_name| is always null-terminated.
out_file_name[out_file_name_size - 1] = '\0';
return nullptr;
}
return object_fd;
}
}

Expand Down

0 comments on commit cd4ef77

Please sign in to comment.