Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC 2013 build has been broken #213

Closed
mmp opened this issue Jul 22, 2017 · 7 comments
Closed

MSVC 2013 build has been broken #213

mmp opened this issue Jul 22, 2017 · 7 comments
Labels
bug

Comments

@mmp
Copy link

mmp commented Jul 22, 2017

Building TOT with MSVC2013 gives the error:

(ClCompile target) -> 
  C:\pbrt-v3\src\ext\glog\src\logging.cc(1154): error C2483: 'thread_msg_data' : object with constructor or destructor cannot be declared 'thread' [c:\pbrt-v3\build\src\ext\glog\glog.vcxproj]

It looks like this is due to the changes introduced in 2df0ca3.
@jasminezz
Copy link

@mmp I have the same error ,building with VS2013. Have you solved it ?

@mmp
Copy link
Author

mmp commented Jul 25, 2017

I haven't spent any time working on a work-around/fix.

@siniyake
Copy link

I am stuck in this problem too. Has anyone solved it so far?

shinh added a commit to shinh/glog that referenced this issue Jul 26, 2017
@shinh
Two fixes for zero allocation logging
da23025 
- Do not use non-POD type for TLS. This is for Issue google#213.
- Use GNU's __thread if it's available. On my linux box, cmake
  wrongly thinks __attribute__((thread)), which is for Cygwin,
  is available.
@shinh shinh mentioned this issue Jul 26, 2017
Closed
@shinh
Copy link
Collaborator

shinh commented Jul 26, 2017

Could someone test if this works?

#217

@tangketan
Copy link

It seems just changing thread_msg_data to pointer type is enough, no need to change the CMakeLists.txt.

@sergiud
Copy link
Collaborator

sergiud commented Aug 8, 2017

Please test PR #226.

@sergiud sergiud added the bug label Oct 23, 2017
@sergiud
Copy link
Collaborator

sergiud commented Jan 4, 2018

Fixed in 2fe6508.

@sergiud sergiud closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@shinh @mmp @sergiud @siniyake @tangketan @jasminezz