Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD file will create a conflict with build/ folder #606

Closed
Aymkdn opened this issue Jan 17, 2021 · 2 comments · Fixed by #614
Closed

BUILD file will create a conflict with build/ folder #606

Aymkdn opened this issue Jan 17, 2021 · 2 comments · Fixed by #614
Milestone
0.5

Comments

@Aymkdn
Copy link

Aymkdn commented Jan 17, 2021

Hi,

In the repo there is a BUILD file that creates a conflict when following the CMake instructions because it will try to create a build/ folder.

I renamed the BUILD file and then I've been able to make the project.
@weiyengs
Copy link

Thanks for the helpful tip! It happened to me too!

@edbaunton
Copy link
Contributor

Renaming it to BUILD.bazel in the tree would solve this problem for good. That approach is recommended by bazel.

drigz added a commit to drigz/glog that referenced this issue Mar 1, 2021
@drigz
Rename BUILD to BUILD.bazel.
f318e9e 
This avoids conflicts with build/ on case-insensitive filesystems.

Fixes google#606.
@drigz drigz mentioned this issue Mar 1, 2021
Merged
@drigz drigz closed this as completed in #614 Mar 1, 2021
drigz added a commit that referenced this issue Mar 1, 2021
@drigz
Rename BUILD to BUILD.bazel.
ce50c57 
This avoids conflicts with build/ on case-insensitive filesystems.

Fixes #606.
@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud mentioned this issue May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Rename BUILD to BUILD.bazel. drigz/glog
4 participants
@Aymkdn @sergiud @edbaunton @weiyengs