Missing google::int32 in raw_logging.h.

[xkszltl]

We got the following error when using raw_logging.h.

In file included from bazel-out/k8-opt/bin/external/com_github_google_glog/_virtual_includes/default_glog_headers/glog/raw_logging.h:44:
bazel-out/k8-opt/bin/external/com_github_google_glog/_virtual_includes/default_glog_headers/glog/vlog_is_on.h:113:16: error: no type named 'int32' in namespace 'google'
extern google::int32 kLogSiteUninitialized;
       ~~~~~~~~^
bazel-out/k8-opt/bin/external/com_github_google_glog/_virtual_includes/default_glog_headers/glog/vlog_is_on.h:124:13: error: no type named 'int32' in namespace 'google'
    google::int32** site_flag,
    ~~~~~~~~^
bazel-out/k8-opt/bin/external/com_github_google_glog/_virtual_includes/default_glog_headers/glog/vlog_is_on.h:125:13: error: no type named 'int32' in namespace 'google'
    google::int32* site_default,
    ~~~~~~~~^
bazel-out/k8-opt/bin/external/com_github_google_glog/_virtual_includes/default_glog_headers/glog/vlog_is_on.h:127:13: error: no type named 'int32' in namespace 'google'
    google::int32 verbose_level);
    ~~~~~~~~^
4 errors generated.

Seems the definition is in logging.h but it wasn't included.

• glog/src/glog/logging.h.in

  Lines 113 to 116 in 9733727

  	@ac_google_start_namespace@
  	#if @ac_cv_have_uint16_t@ // the C99 format
  	typedef int32_t int32;

• glog/src/glog/raw_logging.h.in

  Lines 39 to 44 in f8c8e99

  	#include <ctime>
  	@ac_google_start_namespace@
  	#include "glog/log_severity.h"
  	#include "glog/vlog_is_on.h"

[drigz]

I've never seen this before. Are you able to provide a repro, or at least information about the platform on which you're building?

[xkszltl]

$ cat repro.cpp && g++ repro.cpp -o repro -lglog
#include <glog/raw_logging.h>

int main()
{
    RAW_LOG_INFO("");
    return 0;
}
In file included from /usr/local/include/glog/raw_logging.h:44:0,
                 from repro.cpp:1:
/usr/local/include/glog/vlog_is_on.h:113:8: error: ‘int32’ in namespace ‘google’ does not name a type
 extern google::int32 kLogSiteUninitialized;
        ^
/usr/local/include/glog/vlog_is_on.h:124:5: error: ‘int32’ is not a member of ‘google’
     google::int32** site_flag,
     ^
/usr/local/include/glog/vlog_is_on.h:124:21: error: ‘site_flag’ was not declared in this scope
     google::int32** site_flag,
                     ^
/usr/local/include/glog/vlog_is_on.h:125:5: error: ‘int32’ is not a member of ‘google’
     google::int32* site_default,
     ^
/usr/local/include/glog/vlog_is_on.h:125:20: error: ‘site_default’ was not declared in this scope
     google::int32* site_default,
                    ^
/usr/local/include/glog/vlog_is_on.h:126:5: error: expected primary-expression before ‘const’
     const char* fname,
     ^
/usr/local/include/glog/vlog_is_on.h:127:5: error: ‘int32’ is not a member of ‘google’
     google::int32 verbose_level);
     ^
/usr/local/include/glog/vlog_is_on.h:127:32: error: expression list treated as compound expression in initializer [-fpermissive]
     google::int32 verbose_level);
                                ^

$ cat repro.cpp && g++ repro.cpp -o repro -lglog && ./repro
#include <glog/logging.h>
#include <glog/raw_logging.h>

int main()
{
    RAW_LOG_INFO("");
    return 0;
}
I0000 00:00:00.000000 135268 repro.cpp:6] RAW: 

[xkszltl]

All use case of raw_logging.h in glog repo seems to have logging.h included before it, which may be the reason why you didn't notice it.

[drigz]

Thanks for clarifying: it seems this is not Bazel-specific.

@sergiud Is this expected or should raw_logging.h include logging.h itself?

[xkszltl]

Yes it has nothing to do with bazel itself.

[sergiud]

@drigz I don't believe this is expected. Probably no one noticed until now.

[drigz]

@xkszltl Would you like to send a PR to add a #include to raw_logging.h?

[xkszltl]

PR: #713

Could you back port this to old versions as well?
Especially old major versions.

[drigz]

I'm afraid there are no major versions, the last release was 0.5, and the project doesn't have release branches so I don't think that's feasible right now.

[xkszltl]

I'm afraid there are no major versions, the last release was 0.5, and the project doesn't have release branches so I don't think that's feasible right now.

Oh I mean 0.5.1/0.4.1/0.3.6

[sergiud]

This is unlikely to happen due to higher maintenance burden.