Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cleanup): use chrono #1038

Merged
merged 1 commit into from
Jan 5, 2024
Merged

feat(cleanup): use chrono #1038

merged 1 commit into from
Jan 5, 2024

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jan 5, 2024

  • Deprecate type-unsafe EnableLogCleaner interface
  • Increase time resolution allowing to drop timing specific workarounds in unit tests

@sergiud
feat(cleanup): use chrono
c78592b 
* Deprecate type-unsafe EnableLogCleaner interface
* Increase time resolution allowing to drop timing specific
  workarounds in unit tests
@sergiud sergiud added this to the 0.7 milestone Jan 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (fe46778) 59.42% compared to head (c78592b) 59.39%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
- Coverage   59.42%   59.39%   -0.03%     
==========================================
  Files          19       19              
  Lines        2541     2554      +13     
  Branches      908      911       +3     
==========================================
+ Hits         1510     1517       +7     
- Misses        686      689       +3     
- Partials      345      348       +3
Files Coverage Δ
src/glog/logging.h 72.85% <ø> (ø)
src/utilities.h 100.00% <100.00%> (ø)
src/logging.cc 67.62% <77.77%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes

@sergiud sergiud merged commit f88544a into master Jan 5, 2024
268 checks passed
@sergiud sergiud deleted the logcleaner-chrono branch January 5, 2024 19:38
@Porkepix Porkepix mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiud @codecov-commenter