Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better encapsulate internals #1055

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: better encapsulate internals #1055

merged 1 commit into from
Jan 9, 2024

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jan 9, 2024

No description provided.

@sergiud sergiud added this to the 0.7 milestone Jan 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2b5a53c) 60.03% compared to head (f7887f9) 59.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
- Coverage   60.03%   59.12%   -0.91%     
==========================================
  Files          19       19              
  Lines        2580     2574       -6     
  Branches      911      911              
==========================================
- Hits         1549     1522      -27     
- Misses        692      706      +14     
- Partials      339      346       +7     
Files Coverage Δ
src/demangle.cc 50.00% <ø> (ø)
src/raw_logging.cc 93.44% <100.00%> (ø)
src/stacktrace_generic-inl.h 57.14% <ø> (ø)
src/stacktrace_libunwind-inl.h 70.00% <ø> (ø)
src/stacktrace_windows-inl.h 66.66% <ø> (ø)
src/stacktrace_x86-inl.h 65.00% <ø> (ø)
src/symbolize.cc 47.04% <ø> (-7.59%) ⬇️
src/utilities.cc 71.96% <100.00%> (ø)
src/utilities.h 100.00% <ø> (ø)
src/vlog_is_on.cc 61.71% <ø> (ø)
... and 6 more

@sergiud sergiud force-pushed the hide-impl branch 7 times, most recently from ab9e571 to ad43da9 Compare January 9, 2024 22:25
@sergiud sergiud merged commit ec455f2 into master Jan 9, 2024
268 checks passed
@sergiud sergiud deleted the hide-impl branch January 9, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants