Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move to mkdocs-material #1101

Merged
merged 1 commit into from
Jun 11, 2024
Merged

docs: move to mkdocs-material #1101

merged 1 commit into from
Jun 11, 2024

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jun 8, 2024

localhost_8000_stable_
localhost_8000_0 7 1_logging_

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (cc0de6c) to head (0794236).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1101   +/-   ##
=======================================
  Coverage   64.41%   64.41%           
=======================================
  Files          19       19           
  Lines        2563     2563           
  Branches      902      895    -7     
=======================================
  Hits         1651     1651           
  Misses        647      647           
  Partials      265      265           

@sergiud sergiud requested a review from drigz June 8, 2024 23:24
@sergiud
Copy link
Collaborator Author

sergiud commented Jun 8, 2024

@drigz Could you please enable Github Pages deployment from the gh-pages branch (somewhere in project settings) and set the glog project URL to https://google.github.io/glog similar to GoogleTest?

Also, is there a way to prevent Buildkite from building the gh-pages branch?

@sergiud sergiud force-pushed the mkdocs branch 2 times, most recently from f878167 to c1586bf Compare June 9, 2024 11:37
@sergiud sergiud modified the milestones: 0.7.1, 0.8 Jun 9, 2024
@sergiud sergiud force-pushed the mkdocs branch 5 times, most recently from c6817b8 to 6208c43 Compare June 9, 2024 20:00
@sergiud
Copy link
Collaborator Author

sergiud commented Jun 11, 2024

@drigz PTAL

@drigz
Copy link
Member

drigz commented Jun 11, 2024

Hey, sorry, just got back from vacation and it might take me a couple of days to catch up to this, let me know if you need me to just rubber stamp it without looking at the code.

@sergiud
Copy link
Collaborator Author

sergiud commented Jun 11, 2024

Thank you. No need to review. Just adjust the two settings:

  1. Enable Github pages deployment from gh-pages branch.
    image
  2. Set website to https://google.github.io/glog under "edit repository details"

@drigz
Copy link
Member

drigz commented Jun 11, 2024

image

image

Done, apologies for missing the first message!

@sergiud
Copy link
Collaborator Author

sergiud commented Jun 11, 2024

@drigz No worries. This works great now. Thank you!

@sergiud sergiud merged commit cfe648e into master Jun 11, 2024
140 of 268 checks passed
@sergiud sergiud deleted the mkdocs branch June 11, 2024 17:48
sergiud added a commit that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants