-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add MODULE.bazel.lock to .gitignore #1120
Conversation
How have you tested this? I think #1116 might be the better fix here - but if you've tested with wasm then this is the right place to change it. |
I think |
I have no wasm dev environment and no one has contributed a CI test, so I'd lean towards only changing the options we can test. |
OK. This PR is changed to only add MODULE.bazel.lock to .gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have a minor remark though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.