Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add MODULE.bazel.lock to .gitignore #1120

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Conversation

4kangjc
Copy link
Contributor

@4kangjc 4kangjc commented Aug 2, 2024

No description provided.

@drigz
Copy link
Member

drigz commented Aug 2, 2024

How have you tested this?

I think #1116 might be the better fix here - but if you've tested with wasm then this is the right place to change it.

@4kangjc
Copy link
Contributor Author

4kangjc commented Aug 2, 2024

How have you tested this?

I think #1116 might be the better fix here - but if you've tested with wasm then this is the right place to change it.

I think DHAVE_UNWIND and DHAVE_SYMBOLIZE are better together, they are stacktrace related macros, maybe it would be better to move them to linux_or_darwin_copts.

@4kangjc
Copy link
Contributor Author

4kangjc commented Aug 2, 2024

How have you tested this?

I think #1116 might be the better fix here - but if you've tested with wasm then this is the right place to change it.

I just saw #1116. #1116 can indeed solve #1111

@drigz
Copy link
Member

drigz commented Aug 2, 2024

I think DHAVE_UNWIND and DHAVE_SYMBOLIZE are better together, they are stacktrace related macros, maybe it would be better to move them to linux_or_darwin_copts.

I have no wasm dev environment and no one has contributed a CI test, so I'd lean towards only changing the options we can test.

@4kangjc
Copy link
Contributor Author

4kangjc commented Aug 2, 2024

I think DHAVE_UNWIND and DHAVE_SYMBOLIZE are better together, they are stacktrace related macros, maybe it would be better to move them to linux_or_darwin_copts.

I have no wasm dev environment and no one has contributed a CI test, so I'd lean towards only changing the options we can test.

OK. This PR is changed to only add MODULE.bazel.lock to .gitignore

@4kangjc 4kangjc changed the title fix: the stacktrace is not interpreted as symbols with bazel chore: add MODULE.bazel.lock to .gitignore Aug 2, 2024
Copy link
Member

@drigz drigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a minor remark though.

.gitignore Outdated Show resolved Hide resolved
Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sergiud sergiud merged commit b3b9eb9 into google:master Aug 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants